fix: handle empty array in maximumNonAdjacentSum - #1905
Open
shaked-shlomo wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The empty-input guard was 'if (nums.length < 0) return 0', but length is never negative, so it was dead code. For [] the function then read nums[0] (undefined) and returned Math.max(0, undefined) === NaN instead of 0. Change the guard to 'nums.length === 0' and add a test file.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1905 +/- ##
==========================================
+ Coverage 85.91% 86.06% +0.14%
==========================================
Files 379 379
Lines 19778 19778
Branches 3016 3020 +4
==========================================
+ Hits 16993 17022 +29
+ Misses 2785 2756 -29 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 2 approving reviews are required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Dynamic-Programming/MaxNonAdjacentSum.js guards the empty case with:
length is never negative, so this is dead code. For an empty array the function falls through, sets maxIncluding = nums[0] (undefined), skips the loop, and returns Math.max(0, undefined) → NaN instead of 0.
Fix
Use nums.length === 0, matching the clearly-intended behavior. Added a test file (the module had none) covering the empty array, a single element, the documented examples, and an all-negative input.