FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: rgbToHsl no longer mutates its input array by InukaWijerathna · Pull Request #1908 · TheAlgorithms/JavaScript · GitHub

/ JavaScript Public

fix: rgbToHsl no longer mutates its input array #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InukaWijerathna wants to merge 1 commit into
base: master
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 1 Commits 1 Checks 3 Files changed
Open

fix: rgbToHsl no longer mutates its input array #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .js  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion Conversions/RgbHslConversion.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const rgbToHsl = (colorRgb) => {
throw new Error('Input is not a valid RGB color.')
}

let colorHsl = colorRgb
let colorHsl = [...colorRgb]

let red = Math.round(colorRgb[0])
let green = Math.round(colorRgb[1])
Expand Down
7 changes: 7 additions & 0 deletions Conversions/test/RgbHslConversion.test.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,11 @@ describe('RgbHslConversion', () => {
])('Should return the error message.', (colorRgb, expected) => {
expect(() => rgbToHsl(colorRgb)).toThrowError(expected)
})

test('Should not mutate the input array.', () => {
const colorRgb = [24, 98, 118]
const result = rgbToHsl(colorRgb)
expect(colorRgb).toEqual([24, 98, 118])
expect(result).not.toBe(colorRgb)
})
})
Loading
Back | FazBrowse Home | New Git URL