feat(Maths): add Tonelli-Shanks modular square root - #1913
Open
felipeofdev-ai wants to merge 2 commits into
Open
feat(Maths): add Tonelli-Shanks modular square root#1913felipeofdev-ai wants to merge 2 commits into
felipeofdev-ai wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Implements Tonelli–Shanks for odd prime moduli with Legendre check, p≡3 (mod 4) fast path, and Vitest coverage. Signed-off-by: Felipe Fernandes <felipe.of.dev@gmail.com>
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 93.51852% with 7 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #1913 +/- ##
==========================================
+ Coverage 85.91% 85.95% +0.04%
==========================================
Files 379 380 +1
Lines 19778 19886 +108
Branches 3016 3042 +26
==========================================
+ Hits 16993 17094 +101
- Misses 2785 2792 +7 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 2 approving reviews are required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Maths/TonelliShanks.js implementing the Tonelli–Shanks algorithm for modular square roots modulo an odd prime.
Reference: https://en.wikipedia.org/wiki/Tonelli%E2%80%93Shanks_algorithm
Checklist
— Felipe Fernandes · Systems & Agentic AI Engineer
https://github.com/felipeofdev-ai · https://felipeofdev-ai.github.io/