report malformed OCSPResp and OCSPReq input as IOException - #2468
Closed
rootvector2 wants to merge 1 commit into
Closed
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for the PR. Merged with minor revisions. Now up on https://www.bouncycastle.org/betas |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCSPResp(byte[]) and OCSPReq(byte[]) only catch IllegalArgumentException, ClassCastException and ASN1Exception around the decode, so a top-level SEQUENCE that is empty or truncated makes OCSPResponse/OCSPRequest read seq.getObjectAt(0) out of bounds and the ArrayIndexOutOfBoundsException escapes the declared throws IOException (an OCSP client parsing a response, or a responder parsing a request, crashes instead of rejecting the input). Both now surface any RuntimeException from the decode as CertIOException, matching what X509CertificateHolder.parseBytes and X509CRLHolder.parseStream already do. Found while checking the cert byte[] parse entry points for the RuntimeException guard those two classes carry; new OCSPResp(new byte[]{0x30, 0x00}) reproduces it, and the added OCSPMalformedInputTest covers empty/truncated/non-SEQUENCE encodings for both parsers plus a valid request/response round trip.
AI tooling was used to help prepare this change.