reject short sequence in cms content-type parsers - #2469
Closed
rootvector2 wants to merge 1 commit into
Closed
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for the PR. Merged with minor revisions. Now up on https://www.bouncycastle.org/betas |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the cms content-type decoders SignedData, EnvelopedData, AuthenticatedData, AuthEnvelopedData and EncryptedData read their mandatory fields with no lower-bound size check, so a ContentInfo whose inner content is an empty or too-short SEQUENCE leaks a NoSuchElementException/ArrayIndexOutOfBoundsException out of the throws CMSException contract of CMSSignedData(byte[]) and its siblings (the IllegalArgumentException CMSEncryptedData documents) — found auditing the CMS parse entry points; each now rejects a short sequence up front like CompressedData/DigestedData already do, covering the interspersed case where a leading OPTIONAL is claimed and the mandatory fields are then truncated.
AI tooling was used to help prepare this change.