feat!: remove the Discover API surface - #51
Open
nirsha-brd wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Removes the Bright Data Discover API integration (POST/GET https://api.brightdata.com/discover). Deletes the brightdata.discover package and notebooks/07_discover_api.ipynb; removes BrightDataClient.discover() / discover_trigger(); removes the six SyncBrightDataClient verbs (discover, discover_trigger, discover_status, discover_wait, discover_fetch, discover_to_result) and the _discover_service helper; drops the DiscoverResult / DiscoverJob / DiscoverSnapshot exports from brightdata.__init__; and removes the Discover test classes from test_colorless_service_verbs.py and test_sync_client_coverage.py along with the imports they orphaned. The dataset discovery feature is a DIFFERENT product and is untouched: discover_by / discover_new dataset triggers, discover_by_category, InstagramPostsDiscoverPayload / InstagramReelsDiscoverPayload, and the search.* scrapers all remain. BREAKING CHANGE: client.discover(), client.discover_trigger() and the sync discover_* verbs are removed, along with the DiscoverResult, DiscoverJob and DiscoverSnapshot exports.
nirsha-brd
marked this pull request as ready for review
August 12, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Bright Data Discover API integration (POST/GET https://api.brightdata.com/discover).
Changes
The trap worth flagging in review
"discover" means two different products in this repo. 204 files match the string. All but a handful belong to the dataset discovery feature, which this PR does not touch:
I classified each reference before deleting anything. tests/unit/test_x_scraper.py::test_forwarded_on_discover_trigger is likewise unrelated — it is a test name, and its body calls posts_by_profile_trigger.
Verification
Baseline captured on pristine main before any edit, then re-run on this branch.
The suite is fully green before and after. The delta of 8 is exactly the removed Discover tests: 5 from TestDiscoverServiceVerbs and 3 from TestDiscoverSyncPath. No test that existed before fails now.
The single ruff error is setup.py:8:1: I001 Import block is un-sorted or un-formatted — pre-existing and identical on untouched main, in a file this PR never opens.
Import smoke test on the built package:
Python resolves imports at module load, so a dangling reference to the deleted package would surface immediately on import brightdata. It does not.
Migration
Use client.search.google() / bing() / yandex() to find sources and client.scrape_url() to read them.
Version
3.0.0, matching this changelog's precedent — ## Version 2.0.0 carried a ### 🚨 Breaking Changes section for a change of this class. Removing eight public methods and three exported models is breaking.
Out of scope
brightdata/skills still ships a discover-api skill, and its python-sdk-best-practices, live-research and rag-pipeline skills reference client.discover. Those need a follow-up PR.