FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add option to prefix the full subvolume path in snapshot_name by LubosKolouch · Pull Request #342 · digint/btrbk · GitHub

/ btrbk Public

Add option to prefix the full subvolume path in snapshot_name - #342

Open
LubosKolouch wants to merge 1 commit into
digint:masterfrom
LubosKolouch:master
Open

LubosKolouch wants to merge 1 commit into
digint:masterfrom
LubosKolouch:master

Conversation

Copy link
Copy Markdown

No description provided.

digint commented Nov 1, 2020

Copy link
Copy Markdown
Owner

i'm not sure if this completely implements it, looks promising though.
I suspect there might be other places in the code which rely on simple $snapshot_name. not sure though, will have to look at it in detail.

digint commented Dec 26, 2020

Copy link
Copy Markdown
Owner

I've had closer look at it, and I fear your fix only solves part of the problem.

probably patch the path in early (directly in parse_config_line) seems the better approach to me.
Leaving the merge request open for now, as this feature still seems very useful to me.

digint changed the title Proposed implementation for https://github.com/digint/btrbk/issues/304 Add option to prefix the full subvolume path in snapshot_name Dec 26, 2020
digint force-pushed the master branch 6 times, most recently from 594fc6d to dac6350 Compare August 5, 2023 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL