Back button on Android could close the wrong popup - #107
Open
Pitouli wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Before, the code was checking if there was a popup opened, and then was checking if a popup had a view inside. But it was not checking if the view was inside the frontest popup ; so it sometimes routes back a "behind" popup. Additionally, the closed popup / the back routed view was the most behind and not the most in front. With this code, it always acts on the visible popup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the code was checking if there was a popup opened, and then was checking if a popup had a view inside.
But it was not checking if the view was inside the frontest popup ; so it sometimes routes back a "behind" popup.
Additionally, the closed popup / the back routed view was the most behind and not the most in front.
With this code, it always acts on the visible popup.