Description: Ports the PostgreSQL binary event actions migration fix from main to the v1 branch (commit e3ae4ac).
Problem:
_row_to_event reads v0 event rows with raw SQL, so SQLAlchemy has no column type to coerce with and the driver's own binary representation reaches the migration code untouched. psycopg2 returns BYTEA columns as memoryview rather than bytes. The existing isinstance(actions_val, bytes) check failed for memoryview, falling through to the "backend returned an object" path, which silently replaced migrated event actions with an empty EventActions while reporting success.
Solution:
Extended the binary type check to accept bytes, bytearray, and memoryview, with explicit coercion to bytes() before unpickling. The Spanner object path is unchanged. Added a parametrized regression test covering all three binary types.
Testing Plan
Unit Tests:
Added parametrized regression test test_migrate_from_sqlalchemy_pickle_reads_every_binary_column_type covering bytes, bytearray, and memoryview.
All unit tests pass locally: tests/unittests/sessions/migration/test_migration.py, 36 passed.
Manual End-to-End (E2E) Tests:
On v1, unfixed code fails for the memoryview and bytearray cases with actions == {}; fixed code passes all parametrized variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Description: Ports the PostgreSQL binary event actions migration fix from main to the v1 branch (commit e3ae4ac).
Problem:
_row_to_event reads v0 event rows with raw SQL, so SQLAlchemy has no column type to coerce with and the driver's own binary representation reaches the migration code untouched. psycopg2 returns BYTEA columns as memoryview rather than bytes. The existing isinstance(actions_val, bytes) check failed for memoryview, falling through to the "backend returned an object" path, which silently replaced migrated event actions with an empty EventActions while reporting success.
Solution:
Extended the binary type check to accept bytes, bytearray, and memoryview, with explicit coercion to bytes() before unpickling. The Spanner object path is unchanged. Added a parametrized regression test covering all three binary types.
Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
On v1, unfixed code fails for the memoryview and bytearray cases with actions == {}; fixed code passes all parametrized variants.
Checklist