FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: cleanup checkstyle import rules by suraj-qlogic · Pull Request #1503 · googleapis/google-api-java-client · GitHub

/ google-api-java-client Public

fix: cleanup checkstyle import rules - #1503

Merged
elharo merged 2 commits into
googleapis:masterfrom
suraj-qlogic:issue-1466
Mar 13, 2020
ConversationCommits (2)ChecksFiles changed
Merged

fix: cleanup checkstyle import rules#1503
elharo merged 2 commits into
googleapis:masterfrom
suraj-qlogic:issue-1466

Conversation

suraj-qlogic commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

Fixes #1466

suraj-qlogic requested a review from a team March 9, 2020 09:44
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2020
suraj-qlogic changed the title fix : cleanup checkstyle import rules fix: cleanup checkstyle import rules Mar 9, 2020
athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2020
kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2020
elharo reviewed Mar 9, 2020
View reviewed changes
Comment thread checkstyle.xml
elharo suggested changes Mar 9, 2020
View reviewed changes
Comment thread checkstyle.xml
Comment thread checkstyle.xml
suraj-qlogic requested a review from elharo March 11, 2020 07:34
athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 11, 2020
kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 11, 2020
elharo reviewed Mar 11, 2020
View reviewed changes
Comment thread checkstyle.xml
<property name="severity" value="error"/>
</module>

<module name="ImportOrder">

elharo Mar 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure, but perhaps what really needs to be updated is this:

https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml

Why do we have to customize this in this project?

suraj-qlogic Mar 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"@elharo The customization was needed because we do not have formatter plugin enabled in this repository. Due to that import order are not structured properly.

I am planning to enable the formatter plugin after that we would not have to customize this configuration.

I will open a separate PR for that once that is merged will rebase this PR."

suraj-qlogic requested a review from elharo March 12, 2020 04:48
elharo merged commit ce22c0e into googleapis:master Mar 13, 2020
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jul 8, 2020
chore: release 1.30.10 (#1501)
60d83de 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.30.10](https://www.github.com/googleapis/google-api-java-client/compare/v1.30.9...v1.30.10) (2020-07-08)


### Bug Fixes

* cleanup checkstyle import rules ([#1503](https://www.github.com/googleapis/google-api-java-client/issues/1503)) ([ce22c0e](https://www.github.com/googleapis/google-api-java-client/commit/ce22c0ea7d02bd1807eae0076bfe55db1a3b754c))
* cleanup commented code of version control ([#1504](https://www.github.com/googleapis/google-api-java-client/issues/1504)) ([5b1968d](https://www.github.com/googleapis/google-api-java-client/commit/5b1968d7bb05affd211b3403a6acc18c3d0c23d9))


### Dependencies

* remove excess dependencies ([#1502](https://www.github.com/googleapis/google-api-java-client/issues/1502)) ([dbe6287](https://www.github.com/googleapis/google-api-java-client/commit/dbe6287dac5b7340827a03c0977ad8f350b58eae))
* update dependency com.google.oauth-client:google-oauth-client-bom to v1.31.0 ([#1544](https://www.github.com/googleapis/google-api-java-client/issues/1544)) ([ebab80d](https://www.github.com/googleapis/google-api-java-client/commit/ebab80d1fec30bde241a5cb7a3146c89aca5359c))
* update dependency com.google.protobuf:protobuf-java to v3.12.2 ([#1527](https://www.github.com/googleapis/google-api-java-client/issues/1527)) ([a4cdec7](https://www.github.com/googleapis/google-api-java-client/commit/a4cdec7afd3c5fb1b6cb4de05021e156dd9d0a14))
* update google-http-client to v1.36.0 ([#1551](https://www.github.com/googleapis/google-api-java-client/issues/1551)) ([01c635a](https://www.github.com/googleapis/google-api-java-client/commit/01c635a21fc3d7b549b6a19cbf3359cacf04ef47))
* update oauth client ([#1499](https://www.github.com/googleapis/google-api-java-client/issues/1499)) ([b9c222c](https://www.github.com/googleapis/google-api-java-client/commit/b9c222cfdc4578dabca48cfbe64068f4f70d3b18))
* update to Guava 29.0 ([#1516](https://www.github.com/googleapis/google-api-java-client/issues/1516)) ([fda223d](https://www.github.com/googleapis/google-api-java-client/commit/fda223d5da5076396bc896db3227facde17e89e5))


### Documentation

* removes reference to deprecated service (Google+) ([#1530](https://www.github.com/googleapis/google-api-java-client/issues/1530)) ([b257207](https://www.github.com/googleapis/google-api-java-client/commit/b2572075418dbbb86b9da8901184c72966464520))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
elharo elharo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Format warnings at head

5 participants

Back | FazBrowse Home | New Git URL