fix: manage JSONDecodeError exception - #1574
Merged
tseaver merged 8 commits intoOct 21, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
test: copes with possible future regressions
Copy link
Copy Markdown
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Sorry, something went wrong.
tseaver
suggested changes
Oct 19, 2021
tseaver
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@gparonitti Thank you for the patch!
Sorry, something went wrong.
test: copes with possible future regressions
Copy link
Copy Markdown
Contributor
Author
|
Pushed the requested changes on main. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Next time please make the commit message for the "fix" different (e.g., fix: address review comments). I initially thought you had force-pushed your branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yes, I didn't think that it was a new commit. Sorry. |
Sorry, something went wrong.
tseaver
suggested changes
Oct 19, 2021
Comment thread
googleapiclient/model.py
Outdated
Comment thread
googleapiclient/model.py
Outdated
Comment thread
googleapiclient/model.py
Comment thread
tests/test_json_model.py
test: User passes a non-str as content
tseaver
suggested changes
Oct 21, 2021
tseaver
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@gparonitti Thanks for persevering! Just one more change needed.
Sorry, something went wrong.
Comment thread
tests/test_json_model.py
Outdated
tseaver
approved these changes
Oct 21, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.28.0](https://www.github.com/googleapis/google-api-python-client/compare/v2.27.0...v2.28.0) (2021-10-26) ### Features * **admin:** update the api 34eef11 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **analyticsadmin:** update the api 8666e3e ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **analyticsdata:** update the api a362e49 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **analyticsreporting:** update the api ec6bf30 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **androidpublisher:** update the api 1a6d12e ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **apigee:** update the api afc34ee ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **artifactregistry:** update the api 421f4d1 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **chat:** update the api ba90d3f ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **cloudkms:** update the api f06247e ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **containeranalysis:** update the api 1589896 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **content:** update the api 8f976a9 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **datacatalog:** update the api b7876fd ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **dataproc:** update the api 742a2f7 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **dialogflow:** update the api 117de7b ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **displayvideo:** update the api 6abb35b ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **eventarc:** update the api 5964672 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **file:** update the api 3508025 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **firestore:** update the api 851dba5 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **gkehub:** update the api b62aef0 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **iam:** update the api 50c48df ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **monitoring:** update the api eafbb60 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **notebooks:** update the api c6c8169 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **osconfig:** update the api ff7bf38 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **oslogin:** update the api c26d08f ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **playcustomapp:** update the api 1898032 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **privateca:** update the api 8eca373 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **securitycenter:** update the api 7e83274 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **speech:** update the api 1a3763c ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **storagetransfer:** update the api 0901d05 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **storage:** update the api 07237cd ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **texttospeech:** update the api 6622bd8 ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) * **vmmigration:** update the api e29809a ([12d387c](https://www.github.com/googleapis/google-api-python-client/commit/12d387c95170487c8da93d4db25acf0bda4a2d2e)) ### Bug Fixes * manage JSONDecodeError exception ([#1574](https://www.github.com/googleapis/google-api-python-client/issues/1574)) ([7d63027](https://www.github.com/googleapis/google-api-python-client/commit/7d630270758459225f7169a03e9a6973b9e5ad82)) ### Documentation * update thread_safety.md ([#1568](https://www.github.com/googleapis/google-api-python-client/issues/1568)) ([0b400f9](https://www.github.com/googleapis/google-api-python-client/commit/0b400f97be45808ade211ca8291b2e1d9476bde1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1570 🦕
The test copes with possible future regressions