FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(tests): enable core_deps presubmit check by daniel-sanche · Pull Request #18233 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

chore(tests): enable core_deps presubmit check - #18233

Open
daniel-sanche wants to merge 9 commits into
googleapis:mainfrom
daniel-sanche:reenable_core_deps_presubmit
ConversationCommits (9)ChecksFiles changed
Open

chore(tests): enable core_deps presubmit check#18233
daniel-sanche wants to merge 9 commits into
googleapis:mainfrom
daniel-sanche:reenable_core_deps_presubmit

Conversation

daniel-sanche commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR re-enabled the core_deps check on pre-submit, with a few changes.

This test triggers the core_deps_from_source nox session, which will run the unit tests against the unreleased copy of the library present in the codebase

Unlike the previous test:

  • we take advantage of the new sharding system
  • this one only targets handwritten libraries, not all packages in the repo
  • tests are trigged for all handwritten libraries when any core dependency is changed (auth, api_core, proto_plus, etc), or if the test config changed

This change also modified noxfiles, to better support preview packages, and avoid downloading over the network when possible

Tests are blocked on #18230

gemini-code-assist Bot reviewed Aug 27, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces a new core_deps_from_source test session across multiple packages, updating CI scripts to trigger downstream testing of handwritten packages when core dependencies or CI configurations change. Feedback on these changes highlights the need to type-validate loaded JSON metadata and normalize path strings in ci/get_package_shards.py to prevent potential runtime errors and cross-platform issues. Additionally, the fragile while loops used to locate the packages directory in several package noxfile.py files should be replaced with a more robust generator expression to ensure compatibility with preview packages.

Comment thread ci/get_package_shards.py
Comment thread ci/get_package_shards.py Outdated
Comment thread packages/db-dtypes/noxfile.py Outdated
Comment thread packages/google-cloud-documentai-toolbox/noxfile.py Outdated
Comment thread packages/google-cloud-ndb/noxfile.py Outdated
Comment thread packages/googleapis-common-protos/noxfile.py Outdated
Comment thread packages/pandas-gbq/noxfile.py Outdated
Comment thread packages/proto-plus/noxfile.py Outdated
Comment thread packages/sqlalchemy-bigquery/noxfile.py Outdated
Comment thread packages/sqlalchemy-spanner/noxfile.py Outdated
daniel-sanche force-pushed the reenable_core_deps_presubmit branch from 03b5f06 to 4145bf3 Compare August 28, 2026 18:05
daniel-sanche changed the title [DRAFT] chore(tests): enable core_deps presubmit check chore(tests): enable core_deps presubmit check Aug 28, 2026
daniel-sanche marked this pull request as ready for review August 28, 2026 18:22
daniel-sanche requested review from a team as code owners August 28, 2026 18:22
daniel-sanche requested review from sindhuvy and removed request for a team August 28, 2026 18:22
daniel-sanche marked this pull request as draft August 28, 2026 18:23
daniel-sanche marked this pull request as ready for review August 28, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sindhuvy Awaiting requested review from sindhuvy sindhuvy is a code owner automatically assigned from googleapis/bigquery-dataframe-team
1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

daniel-sanche

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL