chore(tests): break up sqlalchemy system tests - #18239
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request configures a dedicated Kokoro job for SQLAlchemy compliance tests and updates the system job to skip them. Feedback on the changes suggests adding the missing build_file definition to the new Kokoro configuration to prevent job failures, and using safer parameter expansion in the shell script to avoid unbound variable errors.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| |GA| |pypi| |versions| | ||
|
|
||
| `SQLALchemy Dialects`_ | ||
| `SQLAlchemy Dialects`_ |
There was a problem hiding this comment.
I asked Gemini to find typos to fix to trigger the tests, instead of adding a temporary change. It found a couple!
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
Sqlalchemy-spanner and sqlalchemy-bigquery have two sets of integration tests: standard system tests, and "compliance" checks. Each of these can take > 1 hour, which can put strain on our single kokoro system test when run sequentially
This PR drops the compliance checks from the Kokoro System check, and breaks them out into their own test run