FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(samples): new Doc AI samples for v1beta3 by aribray · Pull Request #44 · googleapis/python-documentai · GitHub

This repository was archived by the owner on Sep 20, 2023. It is now read-only.
/ python-documentai Public archive

docs(samples): new Doc AI samples for v1beta3 - #44

Merged
leahecole merged 49 commits into
googleapis:masterfrom
aribray:python-docai
Oct 21, 2020
ConversationCommits (49)ChecksFiles changed
Merged

docs(samples): new Doc AI samples for v1beta3#44
leahecole merged 49 commits into
googleapis:masterfrom
aribray:python-docai

Conversation

aribray commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

aribray requested a review from a team as a code owner October 15, 2020 19:44
aribray requested review from a team and engelke October 15, 2020 19:44
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
telpirion reviewed Oct 15, 2020
View reviewed changes
Comment thread samples/process_document_sample_v1beta3.py Outdated
telpirion reviewed Oct 15, 2020
View reviewed changes

telpirion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think that the sample test are in the wrong place. We typically place the tests in the same folder as the script under test.

E.g. quickstart_test.py is in the same folder as quickstart.py

Comment thread samples/quickstart_sample_v1beta3.py Outdated
Comment thread samples/process_document_sample_v1beta3.py Outdated
Comment thread samples/batch_process_documents_sample_v1beta3.py Outdated
Comment thread samples/batch_process_documents_sample_v1beta3.py Outdated
Comment thread samples/batch_process_documents_sample_v1beta3.py Outdated
Comment thread samples/quickstart_sample_v1beta3.py Outdated
Comment thread tests/unit/gapic/documentai_v1beta3/quickstart_v1beta3_test.py Outdated
Comment thread tests/unit/gapic/documentai_v1beta3/quickstart_v1beta3_test.py Outdated
Comment thread tests/unit/gapic/documentai_v1beta3/quickstart_v1beta3_test.py Outdated
Comment thread tests/unit/gapic/documentai_v1beta3/quickstart_v1beta3_test.py Outdated
telpirion reviewed Oct 15, 2020
View reviewed changes
Comment thread samples/process_document_sample_v1beta3.py Outdated
telpirion reviewed Oct 15, 2020
View reviewed changes
Comment thread samples/quickstart_sample_v1beta3.py Outdated
telpirion reviewed Oct 15, 2020
View reviewed changes
Comment thread samples/quickstart_sample_v1beta3.py Outdated
telpirion requested a review from leahecole October 15, 2020 22:26
leahecole removed the request for review from engelke October 15, 2020 22:29
leahecole added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 15, 2020

leahecole commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

putting a do not merge on it right away because the samples checks aren't running - I'll look into that because I'm like 99% sure it's not your fault Ari :)

leahecole commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

blocked by internal CL 337396830 to make checks run

leahecole commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Alright - CL merged, let's see if the checks show up

aribray requested a review from leahecole October 19, 2020 23:22
leahecole suggested changes Oct 20, 2020
View reviewed changes

leahecole left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A couple of hopefully quick things! We're so close!

Comment thread samples/snippets/batch_process_documents_sample_v1beta3.py
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated
Comment thread samples/snippets/process_document_sample_v1beta3_test.py Outdated
aribray requested a review from leahecole October 20, 2020 22:50
leahecole suggested changes Oct 21, 2020
View reviewed changes
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py
Comment thread samples/snippets/process_document_sample_v1beta3_test.py
Comment thread samples/snippets/quickstart_sample_v1beta3_test.py
aribray requested a review from leahecole October 21, 2020 05:39
leahecole suggested changes Oct 21, 2020
View reviewed changes
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated
Comment thread samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated
aribray and others added 3 commits October 21, 2020 15:26
Apply suggestions from code review to resolve exception
0849731 
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
resolve exception
61f0c7f
lint
80d0fb4
leahecole removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 21, 2020
leahecole merged commit cc8c58d into googleapis:master Oct 21, 2020
gcf-merge-on-green Bot pushed a commit that referenced this pull request Mar 25, 2021
chore: release 0.4.0 (#57)
a75c42a 
🤖 I have created a release \*beep\* \*boop\*
---
## [0.4.0](https://www.github.com/googleapis/python-documentai/compare/v0.3.0...v0.4.0) (2021-03-25)


### Features

* add 'from_service_account_info' factory to clients ([d6f183a](https://www.github.com/googleapis/python-documentai/commit/d6f183a696b211c6d29bc28e9bbd0a8537f65577))
* add common resource path helpers, expose client transport ([#43](https://www.github.com/googleapis/python-documentai/issues/43)) ([4918e62](https://www.github.com/googleapis/python-documentai/commit/4918e62033b4c118bf99ba83730377b4ecc86d17))
* add documentai v1 ([#101](https://www.github.com/googleapis/python-documentai/issues/101)) ([74fabb5](https://www.github.com/googleapis/python-documentai/commit/74fabb5e260ecc27e9cf005502d79590fa7f72e4))
* add from_service_account_info factory and fix sphinx identifiers  ([#80](https://www.github.com/googleapis/python-documentai/issues/80)) ([d6f183a](https://www.github.com/googleapis/python-documentai/commit/d6f183a696b211c6d29bc28e9bbd0a8537f65577))


### Bug Fixes

* added if statement to filter out dir blob files ([#63](https://www.github.com/googleapis/python-documentai/issues/63)) ([7f7f541](https://www.github.com/googleapis/python-documentai/commit/7f7f541bcf4d2f42b2f619c2ceb45f53c5d0e9eb))
* adds comment with explicit hostname change ([#94](https://www.github.com/googleapis/python-documentai/issues/94)) ([bb639f9](https://www.github.com/googleapis/python-documentai/commit/bb639f9470304b9c408143a3e8091a4ca8c54160))
* fix sphinx identifiers ([d6f183a](https://www.github.com/googleapis/python-documentai/commit/d6f183a696b211c6d29bc28e9bbd0a8537f65577))
* moves import statment inside region tags ([#71](https://www.github.com/googleapis/python-documentai/issues/71)) ([a04fbea](https://www.github.com/googleapis/python-documentai/commit/a04fbeaf026d3d204dbb6c6cecf181068ddcc882))
* remove client recv msg limit and add enums to `types/__init__.py` ([#72](https://www.github.com/googleapis/python-documentai/issues/72)) ([c94afd5](https://www.github.com/googleapis/python-documentai/commit/c94afd55124b0abc8978bf86b84743dd4afb0778))
* removes C-style semicolons and slash comments ([#59](https://www.github.com/googleapis/python-documentai/issues/59)) ([1b24bfd](https://www.github.com/googleapis/python-documentai/commit/1b24bfdfc603952db8d1c633dfde108a396aa707))
* **samples:** swaps 'continue' for 'return' ([#93](https://www.github.com/googleapis/python-documentai/issues/93)) ([dabe48e](https://www.github.com/googleapis/python-documentai/commit/dabe48e8c1439ceb8a50c18aa3c7dca848a9117a))


### Documentation

* fix pypi link ([#46](https://www.github.com/googleapis/python-documentai/issues/46)) ([5162674](https://www.github.com/googleapis/python-documentai/commit/5162674091b9a2111b90eb26739b4e11f9119582))
* **samples:** new Doc AI samples for v1beta3 ([#44](https://www.github.com/googleapis/python-documentai/issues/44)) ([cc8c58d](https://www.github.com/googleapis/python-documentai/commit/cc8c58d1bade4be53fde08f6a3497eb3f79f63b1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
leahecole leahecole approved these changes
telpirion telpirion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL