FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: add type annotations to codebase by plamut · Pull Request #509 · googleapis/python-pubsub · GitHub

This repository was archived by the owner on Mar 9, 2026. It is now read-only.
/ python-pubsub Public archive

docs: add type annotations to codebase - #509

Merged
gcf-merge-on-green[bot] merged 10 commits into
googleapis:mainfrom
plamut:iss-500
Oct 1, 2021
ConversationCommits (10)ChecksFiles changed
Merged

docs: add type annotations to codebase#509
gcf-merge-on-green[bot] merged 10 commits into
googleapis:mainfrom
plamut:iss-500

Conversation

plamut commented Sep 28, 2021

Copy link
Copy Markdown
Contributor

Closes #500.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

plamut requested review from a team, anguillanneuf and pradn September 28, 2021 13:50
product-auto-label Bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 28, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021

plamut commented Sep 28, 2021

Copy link
Copy Markdown
Contributor Author

NOTE: py.typed file (PEP 561) marker was intentionally not added, as this could break the workflows of users that use mypy for type checks. This happened in BigQuery, for example.

We will thus likely add py.typed once we know for sure that mypy is happy with our type annotations.

anguillanneuf approved these changes Oct 1, 2021
View reviewed changes

anguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is great! Thanks a lot!

pradn approved these changes Oct 1, 2021
View reviewed changes

pradn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thanks!

plamut commented Oct 1, 2021

Copy link
Copy Markdown
Contributor Author

Thank you both for the reviews!

plamut added the automerge Merge the pull request once unit tests and other checks pass. label Oct 1, 2021
gcf-merge-on-green Bot merged commit 093cabf into googleapis:main Oct 1, 2021
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 1, 2021
plamut deleted the iss-500 branch October 1, 2021 19:28
gcf-merge-on-green Bot pushed a commit that referenced this pull request Nov 10, 2021
chore: release 2.9.0 (#522)
5c8e9db 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.9.0](https://www.github.com/googleapis/python-pubsub/compare/v2.8.0...v2.9.0) (2021-11-10)


### Features

* add context manager support in client ([#516](https://www.github.com/googleapis/python-pubsub/issues/516)) ([51eae67](https://www.github.com/googleapis/python-pubsub/commit/51eae67c47e2ce7d2f7620209e98df4a129801b5))
* add support for Python 3.10 ([#518](https://www.github.com/googleapis/python-pubsub/issues/518)) ([bb25d75](https://www.github.com/googleapis/python-pubsub/commit/bb25d755d70ba19e69d8a281be65f13eb994967d))


### Bug Fixes

* add 'dict' annotation type to 'request' ([b72522a](https://www.github.com/googleapis/python-pubsub/commit/b72522a4617c4b2773fb6a5a631038791aa08300))
* **deps:** drop packaging dependency ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
* **deps:** require google-api-core >= 1.28.0 ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
* improper types in pagers generation ([2ad639d](https://www.github.com/googleapis/python-pubsub/commit/2ad639d6370c7a085498595d7bd0d7eaadfff3c1))


### Documentation

* add type annotations to codebase ([#509](https://www.github.com/googleapis/python-pubsub/issues/509)) ([093cabf](https://www.github.com/googleapis/python-pubsub/commit/093cabff9f0464b1dfaa8f373b6fffbc439518de))
* list oneofs in docstring ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
release-please Bot mentioned this pull request Aug 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
pradn pradn approved these changes
anguillanneuf anguillanneuf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add type annotations to the codebase

3 participants

Back | FazBrowse Home | New Git URL