FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add support for open telemetry by vi3k6i5 · Pull Request #633 · googleapis/python-spanner-django · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner-django Public archive

feat: Add support for open telemetry - #633

Merged
vi3k6i5 merged 17 commits into
googleapis:masterfrom
vi3k6i5:opentelemetry
Jun 17, 2021
ConversationCommits (17)ChecksFiles changed
Merged

feat: Add support for open telemetry#633
vi3k6i5 merged 17 commits into
googleapis:masterfrom
vi3k6i5:opentelemetry

Conversation

vi3k6i5 commented May 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add support for open telemetry tracing if open telemetry is installed.
Added the same as extra dependency.

Also added unit tests for the same.

Follow up PR to add tracing in schema with related checks in unit tests. #648

Fixes #633 🦕

vi3k6i5 requested a review from a team May 20, 2021 12:46
product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label May 20, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021
vi3k6i5 mentioned this pull request Jun 10, 2021
Closed

snippet-bot Bot commented Jun 11, 2021

Copy link
Copy Markdown

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

c24t approved these changes Jun 15, 2021
View reviewed changes

c24t left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The way we're testing OT is kind of surprising, but that's largely OT's fault for being difficult to test. A few minor comments, but LGTM.

Comment thread tests/_helpers.py
Comment thread tests/unit/django_spanner/simple_test.py
Comment thread django_spanner/_opentelemetry_tracing.py Outdated
larkee reviewed Jun 15, 2021
View reviewed changes

larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So this adds the trace_call method but does not add any calls. This means there is no tracing being added to the library. Is the intention for users to add trace calls themselves?

For the Spanner Client and the SQLAlchemy connector, we added tracing within the libraries. See here and here for more context.

vi3k6i5 commented Jun 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

So this adds the trace_call method but does not add any calls. This means there is no tracing being added to the library. Is the intention for users to add trace calls themselves?

For the Spanner Client and the SQLAlchemy connector, we added tracing within the libraries. See here and here for more context.

So that will have to be a follow up PR, since this PR was already crossing 300 lines, I didn't add it here. Updated the description to reflect the same info.

vi3k6i5 mentioned this pull request Jun 16, 2021
Merged
vi3k6i5 requested a review from larkee June 17, 2021 06:39
vi3k6i5 merged commit 2ba879a into googleapis:master Jun 17, 2021
This was referenced Apr 17, 2024
Closed
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

skuruppu Awaiting requested review from skuruppu
thiagotnunes Awaiting requested review from thiagotnunes
asthamohta Awaiting requested review from asthamohta
larkee Awaiting requested review from larkee
1 more reviewer
c24t c24t approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL