Implement :fiber_switch trace event - #9603
Open
headius wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This is mostly working, but does not yet pass CRuby's test_fiber_switch in test_setttracefunc.rb for a few reasons: * The current thread check there is incompatible with JRuby's Thread.current being different for each Fiber. * Raise events are not being triggered from Fiber.raise or Fiber errors. As usual, for accurate file and line numbers, it should be run with --debug. Might be enough for jruby#9600.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly working, but does not yet pass CRuby's test_fiber_switch in test_setttracefunc.rb for a few reasons:
As usual, for accurate file and line numbers, it should be run with --debug.
Might be enough for #9600.