Making parse_config accepts a String like Ruby MRI - #303
Open
edipofederle wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@kares maybe we can take a quick look into this one? thanks |
Sorry, something went wrong.
kares
reviewed
Jun 7, 2024
Comment thread
lib/openssl/config.rb
Outdated
Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
Copy link
Copy Markdown
Member
|
Seems like this is ready to go? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
did look into this but did not figure out a path fwd. the logic isn't matching what MRI is doing (in native C)...
@headius but if it looks good to you, feel free to merge. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Ruby MRI, we can do:
OpenSSL::Config.parse_config("") # also accepts a String
but not with JRuby: