chore: allow esbuild build scripts to fix fresh-clone install - #234
DylanPiercey wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR. To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: bae354bb-4f9c-4d6b-bc9c-b327e19ceebe 📥 CommitsReviewing files that changed from the base of the PR and between d3ab41b and 073a799. 📒 Files selected for processing (1)
Comment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
|
Closing — this was based on my misreading of "fresh clone". The actual issue is at the pnpm create scaffold level, not this repo's own install (which installs cleanly in CI; esbuild isn't in its resolved tree). Replacing with a fix in @marko/create that approves the scaffold's esbuild build. |
Sorry, something went wrong.
A fresh clone's pnpm install fails with ERR_PNPM_IGNORED_BUILDS: esbuild. esbuild is an optional peer of vite (pulled in by vitest) and ships a postinstall that pnpm 10+ blocks by default, erroring on first install until it's approved.
Whitelists it via onlyBuiltDependencies in pnpm-workspace.yaml (what pnpm approve-builds writes) so clones install cleanly.