fix: report comments before a comma-continued concise attr line - #250
DylanPiercey merged 1 commit into
Conversation
Sorry, something went wrong.
At a newline in a concise open tag, the parser looks ahead past whitespace and comments for a `,` that continues the tag on the next line, and jumped past everything it skipped, so the comments on those lines reached no handler and consumers dropped them. It now steps past only the newline and parses the rest as part of the open tag, which reports each comment through `onOpenTagComment`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: ddd3901 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 35 35
Lines 4611 4611
Branches 888 888
=======================================
Hits 4609 4609
Misses 2 2 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: cc512e18-3d41-4450-919a-8d2cc5f7cb90 📥 CommitsReviewing files that changed from the base of the PR and between c84a938 and ddd3901. ⛔ Files ignored due to path filters (2)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. WalkthroughThe concise open-tag scanner now keeps comments before a comma-continued attribute line within the open tag. A fixture adds comments before a type attribute, and a changeset describes reporting those comments through onOpenTagComment. A separate benchmark note documents pnpm setup commands for cloned references and records an observed npm install failure. Merge Risk: ⚪ Minimal · up to ddd39 The intended comment-reporting behavior is covered by the parser wiring and fixture snapshots; the PR is mergeable. 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Comment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
In a concise open tag, the parser looks ahead from a newline past whitespace and comments for a , that continues the tag on the next line. When it found one, it jumped past everything it had skipped, so comments on those lines reached no handler and consumers dropped them (e.g. prettier-plugin-marko deleted them on format). It now steps past only the newline and lets the open tag parse the rest, which reports each comment through onOpenTagComment, like any other comment that stands alone in an open tag.
Also files an agent-feedback item for the bench's COMPARE mode, which installs the compared ref with npm ci and fails in this pnpm repo.
🤖 Generated with Claude Code