flatten: document how recursion survives flattening - #1244
Open
reuvenharrison wants to merge 2 commits into
Open
flatten: document how recursion survives flattening#1244reuvenharrison wants to merge 2 commits into
reuvenharrison wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
The package doc and the public allOf guide now state the invariant the merge maintains (every cycle-closing edge carries a $ref, kept, named via a component, or hoisted as AllOfMergedN) and what a user may see in flattened output (generated components, residual allOf around recursion points). MergeSpec's doc says it names the anchored cycles, which is the half of its job the comment omitted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDvUFsg5nu1NBWQffErGDw
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1244 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 345 345
Lines 14336 14336
=======================================
Hits 13229 13229
Misses 1107 1107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDvUFsg5nu1NBWQffErGDw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only follow-up to the #1233/#1240/#1243 sequence, closing the gap between what the code does and what its overviews say:
The function-level comments from the sequence (anchored, splitInFlight/anchorInFlight, nameAnchoredCycles, the diff-side guard and cut-counter comments) were audited and already state the model correctly; no changes there.