Repository navigation
Add DrawingRenderContext - #2168
IngeborgAtRS wants to merge 3 commits into
Conversation
Sorry, something went wrong.
* Add a new rendering context for WPF that renders the graph to a DrawingGroup instead of creating WPF elements. This improves performance slightly but most importantly, it avoids the nasty behavior of creating new children to the Canvas during the Render phase. When there are a lot of curves this can cause the WPF Measure/Arrange/Render cycle to break and fail to redraw the curves. * Create a base class WpfRenderContext that holds functionality shared between the different rendering modes. PlotView.RenderContext now returns this type instead of CanvasRenderContext. * Tooltips now work in the PlotView if you use the DrawingRenderContext. * Create a CanvasPlotView in ExampleBrowser.WPF that * Replace Assert.Is* with Assert.That(..., Is.*) in all tests to get rid of legacy NUnit calls * Fix one of the Issues examples that fails unexpectedly if the current culture does not use dot at decimal separator.
|
@VisualMelon, @objorke, is there anyone that can look at this? |
Sorry, something went wrong.
|
@VisualMelon I understand this is a valuable contribution that could improve the WPF rendering pipeline. But to streamline the manual review process and ensure a clean history, I would recommend the work to be split into several focused pull requests:
@IngeborgAtRS I suggest to update and create new, segmented pull requests following this structure to get these improvements merged smoothly! |
Sorry, something went wrong.
|
@objorke I can absolutely split off these: "Replace Assert.Is* with Assert.That(..., Is.*) in all tests to get rid of legacy NUnit calls Fix one of the Issues examples that fails unexpectedly if the current culture does not use dot at decimal separator." However, the fix to issue 1794 is the introduction of the DrawingRenderContext, so it's hard to extract that into a separate PR. |
Sorry, something went wrong.
|
I see, then I suggest to keep the related bug fix in this PR! |
Sorry, something went wrong.
|
The test updates have now been reverted (except those in PngAssert.cs, since the .Net 10 version fails to build without them). |
Sorry, something went wrong.
Fixes #1794.
Checklist
Changes proposed in this pull request:
Add a new rendering context for WPF that renders the graph to a DrawingGroup instead of creating WPF elements. This improves performance slightly but most importantly, it avoids the nasty behavior of creating new children to the Canvas during the Render phase. When there are a lot of curves this can cause the WPF Measure/Arrange/Render cycle to break and fail to redraw the curves. Make this the default RenderContext for the WPF PlotView.
Create a base class WpfRenderContext that holds functionality shared between the different rendering modes. PlotView.RenderContext now returns this type instead of CanvasRenderContext.
Tooltips now work in the PlotView if you use the DrawingRenderContext.
Create a CanvasPlotView in ExampleBrowser.WPF that uses CanvasRenderContext.
@oxyplot/admins