Fix glob pattern for source paths containing a dot - #4131
Open
lacatoire wants to merge 2 commits into
Open
lacatoire wants to merge 2 commits into
lacatoire wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When a source path contains a dot (e.g. test.1), it was assumed to be a single file and the /**/* suffix was not appended, so phpDocumentor never descended into the directory and reported an empty documentation set. The heuristic is dropped: each path now emits both /path and /path/**/* so that file paths still match exactly and directory paths still recurse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paths containing a dot (e.g. test.1) were treated as a single file and never expanded to /path/**/*, so phpDocumentor reported an empty documentation set when run with -d test.1.
The heuristic is dropped: each path emits both /path and /path/**/*, so file paths still match exactly and directory paths recurse regardless of dots in their names.
Fixes #3940