runtime: extend builtin function DATETIME function support for time - #194
Closed
pgammans wants to merge 1 commit into
Closed
pgammans wants to merge 1 commit into
pgammans wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
eemeli
approved these changes
Dec 30, 2025
eemeli
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
My apologies, this should've really gotten merged ages ago.
@pgammans, there are a few conflicts with changes made on the main branch, would you be willing to take care of those or would you like me to do so? If you were to enable edits by maintainers, that would be a bit easier.
Sorry, something went wrong.
Comment thread
fluent.runtime/fluent/runtime/types.py
Comment on lines
+303
to
+304
| if 'dateStyle' in kwargs and not isinstance(self, (datetime, date)): | ||
| raise TypeError("dateStyle option can only be specified for datetime or time instances, not date instance") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| if 'dateStyle' in kwargs and not isinstance(self, (datetime, date)): | |
| raise TypeError("dateStyle option can only be specified for datetime or time instances, not date instance") | |
| if 'dateStyle' in kwargs and not isinstance(self, (datetime, date)): | |
| raise TypeError("dateStyle option can only be specified for datetime or date instances, not time instance") |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in build DATETIME function has support for python accepting datetime.datetime and datetime.date objects.
This PR extends this support and to include datetime.time.