FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-154060: Preserve replay duration and rate by pablogsal · Pull Request #154101 · python/cpython · GitHub

/ cpython Public

gh-154060: Preserve replay duration and rate - #154101

Merged
pablogsal merged 6 commits into
python:mainfrom
pablogsal:agent/gh-154060-replay-duration-rate
Aug 26, 2026
ConversationCommits (6)ChecksFiles changed
Merged

gh-154060: Preserve replay duration and rate#154101
pablogsal merged 6 commits into
python:mainfrom
pablogsal:agent/gh-154060-replay-duration-rate

Conversation

pablogsal commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jul 19, 2026
Closed
pablogsal changed the title gh-154060: Show replay duration and rate gh-154060: Preserve replay duration and rate Jul 19, 2026
pablogsal added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 19, 2026

pablogsal commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

CC: @lkollar

pablogsal force-pushed the agent/gh-154060-replay-duration-rate branch from 5490417 to 8b117f6 Compare July 19, 2026 14:22
pablogsal marked this pull request as ready for review July 19, 2026 14:28
pablogsal requested a review from AA-Turner as a code owner July 19, 2026 14:28

maurycy commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

I believe this comment #154105 (review) is applicable here as well.

maurycy mentioned this pull request Jul 23, 2026
Open
pablogsal force-pushed the agent/gh-154060-replay-duration-rate branch from 8b117f6 to f637be1 Compare August 25, 2026 23:53
pablogsal merged commit 7f0ccd6 into python:main Aug 26, 2026
54 checks passed
pablogsal deleted the agent/gh-154060-replay-duration-rate branch August 26, 2026 09:24

miss-islington-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7f0ccd6c0e3f85fbaeceb2f67b06ab3631db0480 3.15

pablogsal mentioned this pull request Aug 26, 2026
Open

bedevere-app Bot commented Aug 26, 2026

Copy link
Copy Markdown

GH-156407 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 26, 2026

bedevere-bot commented Aug 26, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Alpine Linux NoGIL 3.x (tierless) has failed when building commit 7f0ccd6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1819/builds/2922) and take a look at the build logs.
  4. Check if the failure is related to this commit (7f0ccd6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1819/builds/2922

Summary of the results of the build (if available):

==

Click to see traceback logs 
Note: switching to '7f0ccd6c0e3f85fbaeceb2f67b06ab3631db0480'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7f0ccd6c0e3f gh-154060: Preserve replay duration and rate (#154101)
Switched to and reset branch 'main'

configure: WARNING: x86_64-pc-linux-musl/gcc is not supported
configure: WARNING:

Platform "x86_64-pc-linux-musl" with compiler "gcc" is not supported by the
CPython core team, see https://peps.python.org/pep-0011/ for more information.


make: *** [Makefile:2476: buildbottest] Error 3

bedevere-bot commented Aug 26, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO + PGO 3.x (tier-3) has failed when building commit 7f0ccd6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1627/builds/3257) and take a look at the build logs.
  4. Check if the failure is related to this commit (7f0ccd6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1627/builds/3257

Summary of the results of the build (if available):

Click to see traceback logs 
Note: switching to '7f0ccd6c0e3f85fbaeceb2f67b06ab3631db0480'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7f0ccd6c0e3f85 gh-154060: Preserve replay duration and rate (#154101)
Switched to and reset branch 'main'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3451: clean-retain-profile] Error 1 (ignored)
./Modules/socketmodule.c: In function ‘getsockaddrarg’:
./Modules/socketmodule.c:2664:9: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
 2664 |         strncpy((char *)sa->salg_name, name, sizeof(sa->salg_name));
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ar: unable to copy file 'libpython3.16.a'; reason: No space left on device
make[2]: *** [Makefile:1164: libpython3.16.a] Error 1
make[1]: *** [Makefile:997: profile-gen-stamp] Error 2
make: *** [Makefile:1009: profile-run-stamp] Error 2

bedevere-bot commented Aug 26, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO 3.x (tier-3) has failed when building commit 7f0ccd6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1654/builds/3221) and take a look at the build logs.
  4. Check if the failure is related to this commit (7f0ccd6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1654/builds/3221

Summary of the results of the build (if available):

Click to see traceback logs 
Note: switching to '7f0ccd6c0e3f85fbaeceb2f67b06ab3631db0480'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7f0ccd6c0e3f8 gh-154060: Preserve replay duration and rate (#154101)
Switched to and reset branch 'main'

ar: unable to copy file 'libpython3.16.a'; reason: No space left on device
make: *** [Makefile:1164: libpython3.16.a] Error 1

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ivonastojanovic Awaiting requested review from ivonastojanovic
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tachyon flamegraph: Replaying binary file doesn’t show time/rate in sidebar

3 participants

Back | FazBrowse Home | New Git URL