gh-154467: Fix empty (Pdb) prompt when attaching to a process with pdb -p - #154469
Merged
ambv merged 1 commit intoJul 27, 2026
Merged
gh-154467: Fix empty (Pdb) prompt when attaching to a process with pdb -p#154469ambv merged 1 commit into
ambv merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ith pdb -p _PdbServer inherits _cmdloop, which wraps cmdloop() in _maybe_use_pyrepl_as_stdin(). That context manager blanks self.prompt to '' so that a local pyrepl draws the prompt itself. The remote server, however, never reads from a local pyrepl -- it transmits self.prompt to the client over the socket -- so the blanking made it send an empty prompt whenever the target process had a pyrepl-capable terminal (pyrepl_input is set). Override _maybe_use_pyrepl_as_stdin() in _PdbServer to a no-op, keeping the real prompt. Add an integration test that attaches to a target running under a pty, so PyREPL is genuinely enabled inside it, and asserts the transmitted prompt is "(Pdb) ". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ambv
force-pushed
the
gh-154467-pdb-remote-prompt
branch
from
04ca7e3 to
98a07de
Compare
July 22, 2026 11:25
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
…ith pdb -p (python#154469) _PdbServer inherits _cmdloop, which wraps cmdloop() in _maybe_use_pyrepl_as_stdin(). That context manager blanks self.prompt to '' so that a local pyrepl draws the prompt itself. The remote server, however, never reads from a local pyrepl -- it transmits self.prompt to the client over the socket -- so the blanking made it send an empty prompt whenever the target process had a pyrepl-capable terminal (pyrepl_input is set). Override _maybe_use_pyrepl_as_stdin() in _PdbServer to a no-op, keeping the real prompt. Add an integration test that attaches to a target running under a pty, so PyREPL is genuinely enabled inside it, and asserts the transmitted prompt is "(Pdb) ". Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-156397 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This needs a backport to 3.15. Details here: #154467 (comment) |
Sorry, something went wrong.
ambv
added a commit
that referenced
this pull request
Aug 26, 2026
…with pdb -p (GH-154469) (GH-156397) gh-154467: Fix empty (Pdb) prompt when attaching to a process with pdb -p (GH-154469) _PdbServer inherits _cmdloop, which wraps cmdloop() in _maybe_use_pyrepl_as_stdin(). That context manager blanks self.prompt to '' so that a local pyrepl draws the prompt itself. The remote server, however, never reads from a local pyrepl -- it transmits self.prompt to the client over the socket -- so the blanking made it send an empty prompt whenever the target process had a pyrepl-capable terminal (pyrepl_input is set). Override _maybe_use_pyrepl_as_stdin() in _PdbServer to a no-op, keeping the real prompt. Add an integration test that attaches to a target running under a pty, so PyREPL is genuinely enabled inside it, and asserts the transmitted prompt is "(Pdb) ". (cherry picked from commit 1ec5607) Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot aarch64 Fedora Stable Refleaks 3.15 (tier-2) has failed when building commit b18a8b6. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/2038/builds/312 Summary of the results of the build (if available): Click to see traceback logsPrevious HEAD position was cfaf610d391 [3.15] gh-154085: Avoid duplicating diff line values (GH-154099) (#156385)
HEAD is now at b18a8b6b0af [3.15] gh-154467: Fix empty (Pdb) prompt when attaching to a process with pdb -p (GH-154469) (GH-156397)
Switched to and reset branch '3.15'
ar: unable to copy file 'libpython3.15d.a'; reason: No space left on device
make: *** [Makefile:1199: libpython3.15d.a] Error 1
make: *** Waiting for unfinished jobs.... |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PdbServer inherits _cmdloop, which wraps cmdloop() in _maybe_use_pyrepl_as_stdin(). That context manager blanks self.prompt to '' so that a local pyrepl draws the prompt itself. The remote server, however, never reads from a local pyrepl -- it transmits self.prompt to the client over the socket -- so the blanking made it send an empty prompt whenever the target process had a pyrepl-capable terminal (pyrepl_input is set).
Override _maybe_use_pyrepl_as_stdin() in _PdbServer to a no-op, keeping the real prompt. Add an integration test that attaches to a target running under a pty, so PyREPL is genuinely enabled inside it, and asserts the transmitted prompt is "(Pdb) ".
This was broken by gh-145379.