gh-155151: Check recursion limits in specialized Python calls - #156346
Open
marinelay wants to merge 1 commit into
Open
gh-155151: Check recursion limits in specialized Python calls#156346marinelay wants to merge 1 commit into
marinelay wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155151
gh-137887 fixed CALL_KW_PY by adding _CHECK_RECURSION_REMAINING before _PUSH_FRAME.
Without this check, the specialized call path could proceed to _PUSH_FRAME even after the recursion budget had been exhausted.
CALL_EX_PY and CALL_KW_BOUND_METHOD use the same _PUSH_FRAME, but were missing the recursion check.
This PR adds the missing _CHECK_RECURSION_REMAINING to both paths, following the same pattern as gh-137887.