gh-156402: Modernize annotation usage in libregrtest - #156403
Open
ashm-dev wants to merge 3 commits into
Open
Conversation
Comment thread
Misc/NEWS.d/next/Tests/2026-08-26-10-06-54.gh-issue-156402.ouqfgaOZ.rst
Outdated
Comment thread
Lib/test/libregrtest/results.py
Outdated
Copy link
Copy Markdown
Member
|
This is churn IMO. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I think it's fine, considering we do use annotations here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It is still churn and can annoy backports because of indentation changes or suppresion of type: ignore. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.