FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

RFC: Revamp TestUtils & tests by bloodyowl · Pull Request #14 · rescript-lang/rescript-react · GitHub

/ rescript-react Public

RFC: Revamp TestUtils & tests - #14

Open
bloodyowl wants to merge 3 commits into
rescript-lang:masterfrom
bloodyowl:revamp-tests
ConversationCommits (3)ChecksFiles changed
Open

RFC: Revamp TestUtils & tests#14
bloodyowl wants to merge 3 commits into
rescript-lang:masterfrom
bloodyowl:revamp-tests

Conversation

bloodyowl commented Mar 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

→ Removes Jest
→ Updates peerDependencies

Test files render

Setup

Assertions setup

Tests

Test output render

JasoonS approved these changes Apr 23, 2021
View reviewed changes

JasoonS left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks clean to me (although I have zero authority here...)

cknitt commented Sep 30, 2022

Copy link
Copy Markdown
Member

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

cristianoc commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

Not sure. Do they add value to justify the maintenance? E.g w.r.t. snapshot test where one just looks at the generated code?

Could go either way. No opinion.

mununki commented Oct 4, 2022

Copy link
Copy Markdown
Member

I have no opinion. Actually, not sure what we should test for the binding module.
One thing that came to my mind is to test the generated js output, maybe?

cristianoc commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

I have no opinion. Actually, not sure what we should test for the binding module.
One thing that came to my mind is to test the generated js output, maybe?

Checking in che compiled output seems by far the easiest thing. And tells everything there is to know.

jderochervlk reviewed Oct 15, 2022
View reviewed changes
Comment thread .github/workflows/nodejs.yml
strategy:
matrix:
node-version: [10.x, 12.x]
node-version: [14.x]

jderochervlk Oct 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should probably add 16 since it's the current LTS release.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jderochervlk jderochervlk left review comments
JasoonS JasoonS approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL