FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat!: support parseable URL values by charliecreates[bot] · Pull Request #158 · shellscape/postcss-values-parser · GitHub

/ postcss-values-parser Public

feat!: support parseable URL values - #158

Open
charliecreates[bot] wants to merge 4 commits into
masterfrom
feat/157-is-parseable-url
ConversationCommits (4)ChecksFiles changed
Open

feat!: support parseable URL values#158
charliecreates[bot] wants to merge 4 commits into
masterfrom
feat/157-is-parseable-url

Conversation

charliecreates Bot commented Apr 22, 2026 •
edited by shellscape
Loading

Copy link
Copy Markdown
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

If yes, please describe the breakage.

The value of isUrl is now determined by different conditions, which could break consumers downstream if relying on older behavior and value of isUrl.

Please Describe Your Changes

  • Add support for parseable URL values.

Resolves #157

charliecreates Bot mentioned this pull request Apr 22, 2026
Open

shellscape commented Apr 22, 2026

Copy link
Copy Markdown
Owner

@CharlieHelps use the pull request template

charliecreates Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Done — I updated the PR body to use the repository pull request template and kept the Resolves #157 linkage.

shellscape requested changes Apr 22, 2026
View reviewed changes

shellscape left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see no tests for the myriad of url('...') variants. And since url is producing a Word, the tests should go into the word tests.

Comment thread test/func.test.ts Outdated
Comment thread test/func.test.ts Outdated
Comment thread src/nodes/Node.ts Outdated
Comment thread docs/Parser.md Outdated
Comment thread docs/Parser.md
Comment thread src/nodes/Word.ts Outdated
Comment thread src/nodes/Word.ts Outdated

shellscape commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

@gwynne I was able to get a review in before I had to step away. please review this when able

shellscape changed the title feat: support parseable URL values feat!: support parseable URL values Apr 22, 2026
gwynne suggested changes Apr 22, 2026
View reviewed changes

gwynne left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Other than the incomplete test coverage, the rest looks correct to me, and a quick local test shows that it fully covers my use case.

Comment thread test/word.test.ts Outdated
shellscape and others added 2 commits May 17, 2026 10:26
Update test/word.test.ts
b755c1e 
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
test: update word URL metadata snapshots
d907ad7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shellscape shellscape requested changes
+1 more reviewer
gwynne gwynne requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

url()s containing file paths are not distinguishable from other arbitrary Word nodes

3 participants

Back | FazBrowse Home | New Git URL