vp_js_runtime: add FreeBSD to the supported OS set - #2552
Open
mfechner wants to merge 1 commit into
Open
mfechner wants to merge 1 commit into
mfechner wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
vp_js_runtime's Os enum only lists Linux, Darwin, and Windows, and Os::current() has a compile_error! for any other target. FreeBSD is a legitimate target for the `vp` binary (the rest of the toolchain builds fine), so add a FreeBSD variant and route it through the same tar.gz + bin/node + bin/ conventions the other unix platforms use. Note: managed Node.js currently has no official FreeBSD build, so `vp env` downloads on FreeBSD will 404 at runtime. That is a distribution gap, not a code gap, and does not block the `vp` binary itself from compiling or running. If/when Node.js publishes FreeBSD artifacts, only the platform_string() mapping in providers/node.rs needs to be updated (FreeBSD -> "freebsd" instead of "linux"). Signed-off-by: Matthias Fechner <mfechner@FreeBSD.org>
Copy link
Copy Markdown
✅ Deploy Preview for viteplus-preview canceled.
|
Sorry, something went wrong.
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Aug 24, 2026
Required patches are recorded upstream: voidzero-dev/vite-plus#2537 voidzero-dev/vite-task#698 voidzero-dev/vite-plus#2552
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp_js_runtime's Os enum only lists Linux, Darwin, and Windows, and Os::current() has a compile_error! for any other target. FreeBSD is a legitimate target for the vp binary (the rest of the toolchain builds fine), so add a FreeBSD variant and route it through the same tar.gz + bin/node + bin/ conventions the other unix platforms use.
Note: managed Node.js currently has no official FreeBSD build, so vp env downloads on FreeBSD will 404 at runtime. That is a distribution gap, not a code gap, and does not block the vp binary itself from compiling or running. If/when Node.js publishes FreeBSD artifacts, only the platform_string() mapping in providers/node.rs needs to be updated (FreeBSD -> "freebsd" instead of "linux").
Fixes #2537