TRD: CalibratorVdExB: Fix minimal entries init - #10439
Merged
martenole merged 1 commit intoDec 6, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Fixes a bug, which was introduced in PR AliceO2Group#10053, where both field for minimal entries were not properly initialized. initProcessing would only be called once hasEnoughData evaluates to true, hence minEntriesTotal would never be properly set. While running locally these probably init to 0. However this caused problems while running on the grid. Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
martenole
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug, which was introduced in PR #10053, where both fields for minimal entries were not properly initialized. initProcessing would only be called once hasEnoughData evaluates to true, hence minEntriesTotal would never be properly set. While running locally these probably init to 0. However this caused problems while running on the grid.
I tested it by inspecting the values for both after initialization of CalibratorVdExB in VdAndExBCalibSpec::init(). Now whenever the device is created the calibration parameters are immediately initialized.
Signed-off-by: Felix Schlepper f3sch.git@outlook.com