FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TRD: CalibratorVdExB: Fix minimal entries init by f3sch · Pull Request #10439 · AliceO2Group/AliceO2 · GitHub

/ AliceO2 Public

TRD: CalibratorVdExB: Fix minimal entries init #10439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martenole merged 1 commit into from
Dec 6, 2022
Conversation 0 Commits 1 Checks 0 Files changed
Merged

TRD: CalibratorVdExB: Fix minimal entries init #10439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .cxx  (1) .h  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
28 changes: 15 additions & 13 deletions Detectors/TRD/calibration/include/TRDCalibration/CalibratorVdExB.h
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "DataFormatsTRD/AngularResidHistos.h"
#include "CCDB/CcdbObjectInfo.h"
#include "DataFormatsTRD/CalVdriftExB.h"
#include "TRDCalibration/CalibrationParams.h"

#include "Rtypes.h"
#include "TProfile.h"
Expand Down Expand Up @@ -85,19 +86,20 @@ class CalibratorVdExB final : public o2::calibration::TimeSlotCalibration<o2::tr
void retrievePrev(o2::framework::ProcessingContext& pc);

private:
bool mInitDone{false}; ///< flag to avoid creating the TProfiles multiple times
size_t mMinEntriesTotal; ///< minimum total number of angular deviations (on average ~3 entries per bin for each TRD chamber)
size_t mMinEntriesChamber; ///< minimum number of angular deviations per chamber for accepting refitted value (~3 per bin)
bool mEnableOutput; ///< enable output of calibration fits and tprofiles in a root file instead of the ccdb
std::unique_ptr<TFile> mOutFile{nullptr}; ///< output file
std::unique_ptr<TTree> mOutTree{nullptr}; ///< output tree
FitFunctor mFitFunctor; ///< used for minimization procedure
std::vector<o2::ccdb::CcdbObjectInfo> mInfoVector; ///< vector of CCDB infos; each element is filled with CCDB description of accompanying CCDB calibration object
std::vector<o2::trd::CalVdriftExB> mObjectVector; ///< vector of CCDB calibration objects; the extracted vDrift and ExB per chamber for given slot
ROOT::Fit::Fitter mFitter; ///< Fitter object will be reused across slots
double mParamsStart[2]; ///< Start fit parameter

ClassDefOverride(CalibratorVdExB, 4);
bool mInitDone{false}; ///< flag to avoid creating the TProfiles multiple times
const TRDCalibParams& mParams{TRDCalibParams::Instance()}; ///< reference to calibration parameters
size_t mMinEntriesTotal{mParams.minEntriesChamber}; ///< minimum total number of angular deviations (on average ~3 entries per bin for each TRD chamber)
size_t mMinEntriesChamber{mParams.minEntriesTotal}; ///< minimum number of angular deviations per chamber for accepting refitted value (~3 per bin)
bool mEnableOutput; ///< enable output of calibration fits and tprofiles in a root file instead of the ccdb
std::unique_ptr<TFile> mOutFile{nullptr}; ///< output file
std::unique_ptr<TTree> mOutTree{nullptr}; ///< output tree
FitFunctor mFitFunctor; ///< used for minimization procedure
std::vector<o2::ccdb::CcdbObjectInfo> mInfoVector; ///< vector of CCDB infos; each element is filled with CCDB description of accompanying CCDB calibration object
std::vector<o2::trd::CalVdriftExB> mObjectVector; ///< vector of CCDB calibration objects; the extracted vDrift and ExB per chamber for given slot
ROOT::Fit::Fitter mFitter; ///< Fitter object will be reused across slots
double mParamsStart[2]; ///< Start fit parameter

ClassDefOverride(CalibratorVdExB, 5);
};

} // namespace trd
Expand Down
6 changes: 0 additions & 6 deletions Detectors/TRD/calibration/src/CalibratorVdExB.cxx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
/// \author Ole Schmidt

#include "TRDCalibration/CalibratorVdExB.h"
#include "TRDCalibration/CalibrationParams.h"
#include "Framework/ProcessingContext.h"
#include "Framework/TimingInfo.h"
#include "Framework/InputRecord.h"
Expand Down Expand Up @@ -135,11 +134,6 @@ void CalibratorVdExB::initProcessing()
}
}

// get parameters
auto& params = TRDCalibParams::Instance();
mMinEntriesChamber = params.minEntriesChamber;
mMinEntriesTotal = params.minEntriesTotal;

mInitDone = true;
}

Expand Down
Back | FazBrowse Home | New Git URL