Add accuracy authorization support (iOS 14+) and authorizationStatus monitoring - #25
Merged
gre4ixin merged 1 commit intoDec 5, 2022
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gre4ixin
self-requested a review
November 19, 2022 21:43
humblehacker
force-pushed
the
add-accuracy-authorization
branch
4 times, most recently
from
b2832ac to
bc02fe0
Compare
November 22, 2022 18:05
gre4ixin
previously approved these changes
Nov 29, 2022
…ageDescriptionDictionary is missing
humblehacker
force-pushed
the
add-accuracy-authorization
branch
from
bc02fe0 to
e9788ff
Compare
November 29, 2022 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found your library easy to work with (nice work!), so I went ahead and added support for CLAccuracyAuthorization, and also added CLAuthorizationStatus monitoring. I also built a quick and dirty sample app that uses these new API - Locations
Update: I also added support for getting and monitoring CLLocationManager.locationServicesEnabled()
Update2: I also fixed a bug where requests for always authorization would be ignored if we already have when-in-use authorization. (See: Request Always Authorization After Getting When In Use)
closes #24