fix stuck authorization request - #31
Merged
gre4ixin merged 2 commits intoDec 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
humblehacker
force-pushed
the
30-fix-stuck-authorization-request
branch
from
a37d735 to
7a293df
Compare
November 28, 2022 22:28
humblehacker
marked this pull request as ready for review
November 28, 2022 22:28
gre4ixin
self-requested a review
November 29, 2022 10:25
…ageDescriptionDictionary is missing
In some circumstances, requesting location permission has no effect. When this happens, the call to request permission never returns. This fix uses the UIApplication state as a proxy for knowing if an authorization dialog has been shown, and when it has been dismissed so we can return a value in the case that the dialog is never shown. fixes AsyncSwift#30
humblehacker
force-pushed
the
30-fix-stuck-authorization-request
branch
from
7a293df to
5d21789
Compare
November 29, 2022 17:41
Copy link
Copy Markdown
Member
|
Hi) i'll review your PR on this week) |
Sorry, something went wrong.
gre4ixin
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I managed to put in a workaround based on this approach. Looking forward to hearing your thoughts on the solution.
This branch comes off my other branch for PR #25, so if you want to see only the changes for this PR, look at the last commit (a37d735).
Fixes #30