FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add type & value fields to primitive json types by dyackzan · Pull Request #915 · BehaviorTree/BehaviorTree.CPP · GitHub

/ BehaviorTree.CPP Public

Add type & value fields to primitive json types - #915

Open
dyackzan wants to merge 1 commit into
BehaviorTree:masterfrom
PickNikRobotics:json-add-fields-to-primitive-types-base-btcpp
ConversationCommits (1)ChecksFiles changed
Open

Add type & value fields to primitive json types#915
dyackzan wants to merge 1 commit into
BehaviorTree:masterfrom
PickNikRobotics:json-add-fields-to-primitive-types-base-btcpp

Conversation

dyackzan commented Jan 29, 2025

Copy link
Copy Markdown

This aligns with how custom types are represented by the JsonExporter.

  • Update both toJson & fromJson functions in the JsonExporter
  • Add & update tests

dyackzan force-pushed the json-add-fields-to-primitive-types-base-btcpp branch 2 times, most recently from 7cff109 to c5561ac Compare January 29, 2025 23:01
Add type & value fields to primitive json types
4f6794d 
This aligns with how custom types are represented by the JsonExporter.

* Update both toJson & fromJson functions in the JsonExporter
* Add & update tests

Co-authored by: David Sobek <david.sobek@picknik.ai>
dyackzan force-pushed the json-add-fields-to-primitive-types-base-btcpp branch from c5561ac to 4f6794d Compare January 29, 2025 23:06

facontidavide commented Jan 31, 2025

Copy link
Copy Markdown
Collaborator
  1. Is this change back-compatible with the previous JSON format?
  2. Can we opt-out if people don't want to use this format?

facontidavide self-requested a review January 31, 2025 15:58

dyackzan commented Jan 31, 2025

Copy link
Copy Markdown
Author
  1. If I understand your meaning correctly then I don't think this is backward compatible: if someone has a JSON serialization of their blackboard with generic types on it from before this change and they try to load it using exporter.fromJson with this change then it will fail and give them the message: "Missing fileld '__type'." I had to update the tests to account for this.
  2. I did not implement a way to opt out of this but I believe this way makes more sense for everything to have a __type field rather than just custom types

Are you thinking you don't want to release this in a non-breaking release if there is no way to opt out?

facontidavide self-assigned this Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

facontidavide Awaiting requested review from facontidavide

Assignees

facontidavide

Labels

BT.CPP-5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL