This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto tree = factory.createTreeFromText(R"(<root BTCPP_format="4">
<BehaviorTree ID="T">
<SleepLeaf/>
</BehaviorTree>
</root>)");
// Tick until the server has accepted the goal. This ensures
// `goal_handle_` is populated inside the BT leaf before we halt.
tree.tickOnce();
for(int i = 0; i < 100 && !goal_received_.load(); ++i)
{
std::this_thread::sleep_for(5ms);
tree.tickOnce();
}
ASSERT_TRUE(goal_received_.load()) << "Server never received the goal; precondition "
"for the race "
"reproducer was not met.";
// The halt must not leak `UnknownGoalHandleError` (or any other
// exception). Before the fix, this throws with
// "Goal handle is not known to this client.".
EXPECT_NO_THROW(tree.haltTree());
// The server must have actually received the cancel request — otherwise
// we'd be testing the non-racing path.
EXPECT_TRUE(cancel_received_.load());
}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(RosActionNode): swallow UnknownGoalHandleError in cancelGoal #129
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
fix(RosActionNode): swallow UnknownGoalHandleError in cancelGoal #129
Filter by extension
Viewed files
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing