FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Action/Server timeout option through ports by MarqRazz · Pull Request #55 · BehaviorTree/BehaviorTree.ROS2 · GitHub

Action/Server timeout option through ports - #55

Open
MarqRazz wants to merge 3 commits into
BehaviorTree:humblefrom
MarqRazz:timeout_port_option
Open

MarqRazz wants to merge 3 commits into
BehaviorTree:humblefrom
MarqRazz:timeout_port_option

Conversation

Copy link
Copy Markdown
Collaborator

This PR adds the option for users to set server_timeout and wait_for_server_timeout through ports specified in the XML file.

MarqRazz commented May 5, 2024

Copy link
Copy Markdown
Collaborator Author

In #60 we have the ability to configure server_timeout and that makes sense to have a global value for wait_for_server_timeout but I still think that users will want the ability to adjust server_timeout per Action/Service. Thoughts?

MarqRazz requested a review from facontidavide May 5, 2024 14:35

Copy link
Copy Markdown
Collaborator Author

Friendly ping @facontidavide 😄

b-adkins commented Jan 4, 2025

Copy link
Copy Markdown
Contributor

In #60 we have the ability to configure server_timeout and that makes sense to have a global value for wait_for_server_timeout but I still think that users will want the ability to adjust server_timeout per Action/Service. Thoughts?

I would find this useful when optimizing bringup. (E.g. for automated full-stack tests.)

We have a behavior tree with a bunch of action clients. Some come up almost immediately, others (e.g. MoveIt) take a little longer.

Copy link
Copy Markdown

This would be a really good addition for me. Is there any progress on getting this merged in?

Copy link
Copy Markdown
Collaborator Author

I would be happy to update this if it is something we are considering to merge in. Otherwise I will close the PR.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL