fix build on x64-windows with msvc - #131
Open
Maxomann wants to merge 1 commit into
Open
Maxomann wants to merge 1 commit into
Maxomann wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This porbably breaks other build configurations (?), but msvc works now. Build was tested using VisualStudio's "Open Folder" option using vcpkg to get the dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This porbably breaks other build configurations (?), but msvc works now.
Build was tested using VisualStudio's "Open Folder" option and using vcpkg to get the dependencies.
The reason for this fix:
During build of target "groot" there were errors about behavior_tree_editor.lib not being found.
It seems that target was not being exported correctly in this configuration (?).
This change removes the behavior_tree_editor target entirely to fix the build.
Also it sets the Compiler Flag "/EHsc" for all projects, to fix other build errors.
As already said, these changes probably break other stuff, but people who want to build the project on windows might find this pull request helpful as a reference.