Update beta with develop updates - #253
Merged
leventeliu merged 29 commits intoFeb 18, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Make observer API writeTimeout = 10 * readTimeout
…enerate new NodeID(by same private node_c private.key) for all client.
Unit all docker client config to same private.key
Support pprof http handler in BlockProducer
Improve unit test cover ratio.
laodouya
approved these changes
Feb 18, 2019
Closed
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## beta #253 +/- ##
==========================================
+ Coverage 75.94% 78.97% +3.02%
==========================================
Files 158 159 +1
Lines 12217 12155 -62
==========================================
+ Hits 9278 9599 +321
+ Misses 2236 1870 -366
+ Partials 703 686 -17 |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## beta #253 +/- ##
==========================================
+ Coverage 75.94% 78.97% +3.02%
==========================================
Files 158 159 +1
Lines 12217 12155 -62
==========================================
+ Hits 9278 9599 +321
+ Misses 2236 1870 -366
+ Partials 703 686 -17 |
Sorry, something went wrong.
leventeliu
approved these changes
Feb 18, 2019
leventeliu
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.