Avoid sampling of NaN center location - #2037
Merged
MMathisLab merged 1 commit intoNov 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MMathisLab
approved these changes
Nov 7, 2022
biol-jsh
added a commit
to biol-jsh/DeepLabCut
that referenced
this pull request
Nov 10, 2022
The current implementation of fliplr breaks when keypoints are hidden since only labels for visible points are forwarded to the pipeline. This is the second attempt at fixing this as an earlier attempt failed due to the error fixed in PR DeepLabCut#2037.
jonahpearl
pushed a commit
to jonahpearl/DeepLabCut
that referenced
this pull request
Nov 27, 2022
MMathisLab
pushed a commit
that referenced
this pull request
Oct 27, 2023
* Fix fliplr augmentation for multi animal 2 The current implementation of fliplr breaks when keypoints are hidden since only labels for visible points are forwarded to the pipeline. This is the second attempt at fixing this as an earlier attempt failed due to the error fixed in PR #2037. * added missing batch_joints append from DLC PR 1946 * made same changes to get_batch_from_video as get_batch. style fixes. * Fix indices when training with identity * Fix and expand unit tests --------- Co-authored-by: Niels Poulsen <niels.poulsen@epfl.ch> Co-authored-by: Jessy Lauer <30733203+jeylau@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1946, np.full(..., np.nan) is required in order for FlipLR to work when keypoints are hidden. Occasionally though, a NaN point can be sampled as crop center
DeepLabCut/deeplabcut/pose_estimation_tensorflow/datasets/augmentation.py
Lines 94 to 107 in ecbb858
This one-liner addresses this bug.