FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix fliplr augmentation for multi animal 2 by biol-jsh · Pull Request #2043 · DeepLabCut/DeepLabCut · GitHub

/ DeepLabCut Public

Fix fliplr augmentation for multi animal 2 - #2043

Merged
MMathisLab merged 7 commits into
DeepLabCut:mainfrom
biol-jsh:patch-1
Oct 27, 2023
ConversationCommits (7)ChecksFiles changed
Merged

Fix fliplr augmentation for multi animal 2#2043
MMathisLab merged 7 commits into
DeepLabCut:mainfrom
biol-jsh:patch-1

Conversation

biol-jsh commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

The current implementation of fliplr breaks when keypoints are hidden since only labels for visible points are forwarded to the pipeline. This is the second attempt at fixing this as an earlier attempt failed due to the error fixed in PR #2037.

biol-jsh and others added 4 commits November 10, 2022 10:36
Fix fliplr augmentation for multi animal 2
1f1ce72 
The current implementation of fliplr breaks when keypoints are hidden since only labels for visible points are forwarded to the pipeline. This is the second attempt at fixing this as an earlier attempt failed due to the error fixed in PR DeepLabCut#2037.
merged main
dd9752c
added missing batch_joints append from DLC PR 1946
6fdb303
made same changes to get_batch_from_video as get_batch. style fixes.
88f9542
n-poulsen mentioned this pull request May 24, 2023
Closed
n-poulsen self-requested a review May 24, 2023 12:49

MMathisLab commented May 25, 2023

Copy link
Copy Markdown
Member

Hi @n-poulsen the tests are failing, can you look into it? FAILED tests/test_pose_multianimal_imgaug.py::test_get_targetmaps[3] - TypeError: get_targetmaps_update() missing 1 required positional argument: 'scale'

jeylau commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

I'm still having some tests failing when training with identity; I'll push a fix as soon as I find why.

jeylau commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Ready to merge @MMathisLab @n-poulsen

MMathisLab commented Oct 27, 2023

Copy link
Copy Markdown
Member

Thanks @jeylau - can we get some # on performance? It won't be a default setting, right? But there are docs for it somewhere? :)

n-poulsen reviewed Oct 27, 2023
View reviewed changes

n-poulsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me!

MMathisLab merged commit 25f8c50 into DeepLabCut:main Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MMathisLab MMathisLab approved these changes
+1 more reviewer
n-poulsen n-poulsen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

MMathisLab

n-poulsen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL