| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
This PR modernizes the Docker build setup by consolidating multiple Dockerfiles into a single multi-stage docker/Dockerfile, replacing the legacy docker/build.sh matrix with a CI-friendly docker buildx bake configuration, and relocating the deeplabcut-docker helper package into docker/package/.
Changes:
Copilot reviewed 10 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file| File | Description |
|---|---|
| docker/package/setup.cfg | Introduces setuptools packaging metadata + console entry point for deeplabcut-docker. |
| docker/package/pyproject.toml | Defines build backend/requirements for the helper package. |
| docker/package/deeplabcut_docker.sh | Adds shell launcher that pulls/builds user-mapped images and runs containers. |
| docker/package/deeplabcut_docker.py | Adds Python CLI wrapper that spawns the shell launcher via a PTY. |
| docker/package/Makefile | Updates README source path for PyPI packaging workflow. |
| docker/package/MANIFEST.in | Ensures package artifacts (README/license/script) are included in builds. |
| docker/package/LICENSE | Adds LGPLv3 license text for the helper package distribution. |
| docker/docker-bake.hcl | Adds buildx bake targets for core + jupyter with versioned and optional latest tags. |
| docker/build.sh | Removes legacy bash build/test/push matrix. |
| docker/README.md | Updates docs for new tags and buildx bake workflow. |
| docker/Dockerfile.test | Removes old dedicated test Dockerfile (replaced by multi-stage Dockerfile). |
| docker/Dockerfile.jupyter | Removes old jupyter Dockerfile (replaced by multi-stage Dockerfile). |
| docker/Dockerfile.core | Removes old core Dockerfile (replaced by multi-stage Dockerfile). |
| docker/Dockerfile.base | Removes old base Dockerfile (replaced by multi-stage Dockerfile). |
| docker/Dockerfile | Adds new multi-stage Dockerfile implementing core/jupyter/test stages. |
| docker/.dockerignore | Adds docker build context ignore rules for a slimmer build context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Looks great, very nice consolidation !
Most comments below are about changing existing behavior rather than improving the layout, and may have been handled elsewhere; please filter accordingly.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks @C-Achard, see my response below! Mostly accepted all suggestions, thanks for the helpful review!
Sorry, something went wrong.
* update deeplabcut_docker: replace shell script with pure python
* update deeplabcut_docker: modernize setup via pyproject.toml
* update deeplabcut_docker README
* docker: fix default user home directory -> home/{user}
* deeplabcut-docker: update print statement passw->token
* deeplabcut-docker: update pyproject.toml Python range 3.10-3.12
There was a problem hiding this comment.
:)
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR is part 1 of updating the docker setup and only entails the Dockerfiles and how we build them. The deeplabcut-docker is also updated, but that is discussed separately in PR #3291 to avoid mixing topics.
adresses #3282, #3285
Motivation
Changes
Not included: