[Docker 2] update deeplabcut-docker package - #3291
Merged
MMathisLab merged 8 commits intoMay 15, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Apr 21, 2026
…update_deeplabcut_docker
deruyter92
marked this pull request as ready for review
April 22, 2026 09:38
C-Achard
reviewed
Apr 23, 2026
C-Achard
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good overall. Some checks could be strengthened (sudo docker check, jupyter validity), but not sure it is worth it given this is meant as a small helper.
I think it's fine to keep the scope tiny.
Also the helper rebuilds a fixed local tag every time. Is that intentional for simplicity, or do we want to avoid repeated rebuilds / potential clashes between concurrent runs?
Let me know what you think is worth addressing, I can approve as-is or we can discuss. Thanks !
Sorry, something went wrong.
Comment thread
docker/package/pyproject.toml
Outdated
Comment thread
docker/package/deeplabcut_docker.py
Outdated
Comment thread
docker/package/deeplabcut_docker.py
Outdated
Comment thread
docker/package/deeplabcut_docker.py
Comment thread
docker/package/deeplabcut_docker.py
…update_deeplabcut_docker
deruyter92
commented
Apr 28, 2026
deruyter92
left a comment
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Thanks @C-Achard for the elaborate review. Addressed all your comments now.
Sorry, something went wrong.
Comment thread
docker/package/deeplabcut_docker.py
Outdated
Comment thread
docker/package/deeplabcut_docker.py
Comment thread
docker/package/deeplabcut_docker.py
Comment thread
docker/package/deeplabcut_docker.py
Outdated
Comment thread
docker/package/pyproject.toml
Outdated
C-Achard
approved these changes
Apr 29, 2026
This was
linked to
issues
May 5, 2026
MMathisLab
pushed a commit
that referenced
this pull request
May 19, 2026
* move deeplabcut-docker package to separate subdirectory * update dockerfile: add single clean dockerfile that replaces the multiple dockerfiles * docker: replace build script with docker bake buildx hcl file * add dockerignore file * docker update README: new dockerfile naming and buildx commands * Update docker/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docker/Dockerfile Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update dockerfile: fix pretrained weights directory permission * dockerfile: add healthcheck for jupyter exposed port * dockerfile: add override jupyter token option + port-expose warning in README.md * dockerfile: add comment regarding root-user * [Docker 2] update `deeplabcut-docker` package (#3291) * update deeplabcut_docker: replace shell script with pure python * update deeplabcut_docker: modernize setup via pyproject.toml * update deeplabcut_docker README * docker: fix default user home directory -> home/{user} * deeplabcut-docker: update print statement passw->token * deeplabcut-docker: update pyproject.toml Python range 3.10-3.12 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Cyril Achard <cyril.achard@epfl.ch>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Part 2 of updating the Docker setup, only concerning the deeplabcut-docker package. This builds on top of earlier refactors of the dockerfiles, discussed in PR #3290
fixes #3282, #3285
Motivation:
The deeplabcut-docker package hasn't been actively maintained for some time and currently it is not working for the jupyter images on Docker Hub. This PR follows PR #3290 in simplifying the organization of Dockerfiles and naming, replaces vendored shell script with pure python, and modernizes the setup via pyproject.toml.