FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update deeplabcut-docker - version 0.1.0 by deruyter92 · Pull Request #3345 · DeepLabCut/DeepLabCut · GitHub

/ DeepLabCut Public

Update deeplabcut-docker - version 0.1.0 - #3345

Merged
deruyter92 merged 2 commits into
mainfrom
jaap/update-dlc-docker
Jun 17, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Update deeplabcut-docker - version 0.1.0#3345
deruyter92 merged 2 commits into
mainfrom
jaap/update-dlc-docker

Conversation

deruyter92 commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR aligns the downstream package deeplabcut-docker with the new DeepLabCut 3.0 release and fixes some final issues before release of the new package (see version bump PR #3351). Note that these are minor additions to a larger previous update in PR #3291.

changes:

  • Bugfix in dockerfile for jupyter image (NOTEBOOK_TOKEN was not evaluated)
  • Update dockerfile default deeplabcut version: 3.0.0
  • Allow local image name / tag
  • better error logging when providing wrong image name
  • warning for empty notebook token
  • version bump + changelog version 0.1.0

deruyter92 marked this pull request as ready for review May 26, 2026 09:06
deruyter92 requested a review from C-Achard May 26, 2026 09:06
C-Achard reviewed May 26, 2026
View reviewed changes

C-Achard left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the changes!
Depending on usefulness feel free to add some of the suggested changes below. The default token is probably the most important point there.

Comment thread docker/package/deeplabcut_docker.py Outdated
Comment thread docker/Dockerfile Outdated
Comment thread docker/package/deeplabcut_docker.py Outdated
Comment thread docker/package/deeplabcut_docker.py
C-Achard added Docker DLC3.0🔥 versioning Related to project’s version number, release identifiers, version metadata labels May 26, 2026
C-Achard added this to the DLC3 milestone May 26, 2026
C-Achard approved these changes May 27, 2026
View reviewed changes

C-Achard left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would suggest adding warnings for empty tokens/disabling auth given the risks documented, otherwise LGTM, thanks!

deruyter92 requested a review from Copilot June 1, 2026 14:52
deruyter92 requested a review from MMathisLab June 1, 2026 14:52
Copilot AI reviewed Jun 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

deruyter92 and others added 2 commits June 2, 2026 10:46
update deeplabcut-docker package (cleanup + bugfix)
1b3fd34 
- bugfix: NOTEBOOK_TOKEN value was never evaluated. This is now fixed
- add features: add supplementary group args; improve logging and exit status; add warning for empty notebook token; allow running with local image
- clean Dockerfile: update default dlc version 3.0; add exec jupyter entrypoint; add warning for empty notebook.
deeplabcut-docker: version 0.1.0 (#3351)
bd69be1
deruyter92 force-pushed the jaap/update-dlc-docker branch from 2a123a0 to bd69be1 Compare June 2, 2026 08:46

deruyter92 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

All comments are addressed. Cleaned up the history so it can be merged without squashing (this preserves the isolated version bump commit, which is preferable).

deruyter92 changed the title Update deeplabcut-docker Update deeplabcut-docker: version 0.1.0 Jun 2, 2026
deruyter92 changed the title Update deeplabcut-docker: version 0.1.0 Update deeplabcut-docker - version 0.1.0 Jun 2, 2026

deruyter92 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

@stes, as the original author of this package we would love hear your feedback, if you have any! Let us know if you would be interested in reviewing this PR. Thanks in advance!

deruyter92 merged commit 0258379 into main Jun 17, 2026
30 checks passed
deruyter92 deleted the jaap/update-dlc-docker branch June 17, 2026 08:11
deruyter92 mentioned this pull request Jul 20, 2026
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
MMathisLab MMathisLab approved these changes
C-Achard C-Achard approved these changes

Assignees

MMathisLab

deruyter92

Labels

DLC3.0🔥 Docker versioning Related to project’s version number, release identifiers, version metadata

Projects

None yet

Milestone

DLC3

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL