| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
As per: an array of numbers is a valid type for chart data. This enables support of floating bar charts. |
Sorry, something went wrong.
|
@awilson9 Thank you for submitting this PR! 🔔 @anuti @FabienLavocat @KentarouTakeda @larrybahr @mernen @josefpaij @danmana @guillaume-ro-fr @archy-bold @braincore @frabnt @alexdor @mahnuh @Conrad777 @adripanico @wertzui @lekoaf @ElianCordoba @indigolain @Ricardo-Mello @rnicholus @mrjack88 @canoceto @nobu222 @Marcoru97 @tonybadguy - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on. If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Sorry, something went wrong.
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
Sorry, something went wrong.
|
@awilson9 Thank you for submitting this PR! Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. 🔔 @anuti @FabienLavocat @KentarouTakeda @larrybahr @mernen @josefpaij @danmana @guillaume-ro-fr @archy-bold @braincore @frabnt @alexdor @mahnuh @Conrad777 @adripanico @wertzui @lekoaf @ElianCordoba @indigolain @Ricardo-Mello @rnicholus @mrjack88 @canoceto @nobu222 @Marcoru97 @tonybadguy - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR {
"type": "info",
"pr_number": 44275,
"author": "awilson9",
"owners": [
"anuti",
"FabienLavocat",
"KentarouTakeda",
"larrybahr",
"mernen",
"josefpaij",
"danmana",
"guillaume-ro-fr",
"archy-bold",
"braincore",
"frabnt",
"alexdor",
"mahnuh",
"Conrad777",
"adripanico",
"wertzui",
"lekoaf",
"ElianCordoba",
"indigolain",
"ricardo-mello",
"rnicholus",
"mrjack88",
"canoceto",
"nobu222",
"Marcoru97",
"tonybadguy"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "342a5c4",
"headCommitOid": "342a5c4bd0c227bfcc576a94b4b907c7f91aec14",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastCommitDate": "2020-04-27T20:00:14.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44275/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"chart.js"
],
"files": [
{
"filePath": "types/chart.js/chart.js-tests.ts",
"kind": "test",
"package": "chart.js"
},
{
"filePath": "types/chart.js/index.d.ts",
"kind": "definition",
"package": "chart.js"
}
],
"otherApprovalCount": 0,
"ownerApprovalCount": 1,
"maintainerApprovalCount": 0,
"hasDismissedReview": false,
"travisResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
Sorry, something went wrong.
|
@awilson9 Everything looks good here. Great job! I am ready to merge this PR on your behalf.
and I'll merge it the next time I look at this PR. |
Sorry, something went wrong.
|
Ready to merge |
Sorry, something went wrong.
|
I just published @types/chart.js@2.9.20 to npm. |
Sorry, something went wrong.
…hart data type by @awilson9 * add number array chart data type * remove newline * linting * syntax error
| Back | FazBrowse Home | New Git URL |
Please fill in this template.
If changing an existing definition: