FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for floating bar chart ([start, end]) by gwyneblaidd · Pull Request #6056 · chartjs/Chart.js · GitHub

/ Chart.js Public

Add support for floating bar chart ([start, end]) - #6056

Merged
simonbrunel merged 4 commits into
chartjs:masterfrom
gwyneblaidd:feat/float-bar
May 21, 2019
ConversationCommits (4)ChecksFiles changed
Merged

Add support for floating bar chart ([start, end])#6056
simonbrunel merged 4 commits into
chartjs:masterfrom
gwyneblaidd:feat/float-bar

Conversation

gwyneblaidd commented Feb 8, 2019 •
edited by simonbrunel
Loading

Copy link
Copy Markdown
Contributor

Rebased float-bar support

Original PR: #5262

gwyneblaidd mentioned this pull request Feb 8, 2019
Closed
benmccann suggested changes Feb 8, 2019
View reviewed changes

benmccann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks like this is very close. There are two failing tests still

Comment thread src/core/core.scale.js Outdated
Comment thread src/scales/scale.logarithmic.js Outdated
simonbrunel changed the title Rebased float-bar support. Flhttps://github.com/chartjs/Chart.js/pull/5262 Add support for floating bar chart ([start, end]) Feb 9, 2019
benmccann reviewed Feb 11, 2019
View reviewed changes
Comment thread src/controllers/controller.bar.js Outdated
benmccann reviewed Feb 11, 2019
View reviewed changes
Comment thread src/controllers/controller.bar.js
benmccann reviewed Feb 11, 2019
View reviewed changes
Comment thread src/core/core.scale.js Outdated
kurkle reviewed Feb 11, 2019
View reviewed changes

kurkle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Things to consider, I'm not saying they should be done though 😄

Comment thread src/controllers/controller.bar.js Outdated
Comment thread src/core/core.scale.js
Comment thread src/scales/scale.logarithmic.js Outdated
Comment thread src/controllers/controller.bar.js Outdated
benmccann reviewed Feb 11, 2019
View reviewed changes
Comment thread src/controllers/controller.bar.js Outdated
benmccann previously approved these changes Feb 18, 2019
View reviewed changes
Comment thread src/controllers/controller.bar.js Outdated
benmccann previously approved these changes Feb 18, 2019
View reviewed changes
benmccann mentioned this pull request Feb 19, 2019
Merged

benmccann commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

@gwyneblaidd #6077 which implements the option not to skip borders has been merged now, so you shouldn't need any changes to element.rectangle.js anymore. Can you rebase the PR? Hopefully the other reviewers can take a look at this PR and we can merge it after that. It's very close. Thanks for sticking with it

I normally don't recommend squashing commits, but I find that if you have many commits then squashing them first makes rebasing easier, so you may want to consider in this case (git rebase HEAD~16, replace pick with s for all but the first commit, comment out all but the first commit message, git push -f)

benmccann mentioned this pull request Mar 2, 2019
Closed
benmccann previously approved these changes Mar 3, 2019
View reviewed changes
benmccann mentioned this pull request Mar 8, 2019
Closed
etimberg requested changes Mar 17, 2019
View reviewed changes
Comment thread src/scales/scale.logarithmic.js Outdated
Comment thread src/scales/scale.logarithmic.js Outdated
Comment thread src/scales/scale.linear.js Outdated
Comment thread src/scales/scale.linear.js
Comment thread src/controllers/controller.bar.js
FLoat-bar support.
762dd88 
_autoSkipp rolled back

minbarlength. float-bar

start fix

start fix

fix

fix

fixes

fix

fix

fix

fixes

unittests

comment removed

reverse of borderSkipped
benmccann previously approved these changes Mar 30, 2019
View reviewed changes
etimberg previously approved these changes Mar 30, 2019
View reviewed changes
nagix reviewed Mar 31, 2019
View reviewed changes

nagix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also, shouldn't we add docs in this PR?

Comment thread test/fixtures/controller.bar/floatBar/float-bar-horizontal.json Outdated

xaviRodri commented Apr 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Good functionality!
Only one question: this [start, end] will only work for the y-axis, or will we be able to do the same in x-axis too?
Something like: {x: [start, end], y: value}
And a result like this:

snyk-bot mentioned this pull request Apr 15, 2020
Open
awilson9 mentioned this pull request Apr 27, 2020
Merged
8 tasks
rr22x mentioned this pull request May 12, 2020
Closed
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Add support for floating bar chart ([start, end]) (chartjs#6056)
0470ce1
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
mend-for-github-com Bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
mend-for-github-com Bot mentioned this pull request Jan 26, 2023
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

simonbrunel simonbrunel approved these changes
kurkle kurkle approved these changes
etimberg etimberg left review comments
+2 more reviewers
benmccann benmccann approved these changes
nagix nagix approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

Version 2.9

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL