| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Mirror TS/JS weak-method guards for Python attribute calls and bare generic callees so suffix_match cannot bind prior_cp.get / run() onto unrelated Methods (G2 / Yui WP-B C2). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Sorry, something went wrong.
|
Thank you for the focused Python same-name fallback suppression and the tests around generic method names. This is now routed as a high-priority parsing fix in 0.9.1-rc and linked to the remaining scope in #1355. This is triage rather than approval; our review queue is full, so the detailed review may take a little time, especially because the PR addresses only one part of the broader binding problem. |
Sorry, something went wrong.
|
The false-positive class is real (prior_cp.get resolving to an unrelated _SessionRegistry.get is exactly the #1276 family) and mirroring the TS/JS guard is the right instinct. Three things before this can merge: (1) mechanical — the branch conflicts, DCO and lint are red, and all three pr-smoke legs fail; rebase + sign-off + lint first. (2) The blanket is_method=true for every Python attribute call in extract_calls.c changes semantics for every other is_method consumer — narrow it or make the case. (3) The hardcoded {get,run,execute} blacklist plus blanket weak-member suppression is a recall cut on a priority language: our #1000 lesson is that graph-shape changes need corpus-scale evidence, so please include Django-scale before/after edge counts (we can help run them once the branch is green). Related work just landed you should build on: #1647 now suppresses cross-language suffix_match CALLS. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Motivation (Yui WP-B C2 / G2)
On a large Python repo, trace_path hop-1 showed fabricated CALLS:
Strong strategies (import_map, same_module, lsp_*) are kept.
Test plan
Made with Cursor