| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Two same-named symbols in different languages were collapsed by suffix_match onto one winner, so get_architecture hotspots inherited the other language's in-degree. unique_name (candidates==1) is DeusData#1572 and is left unchanged. JS/TS/TSX stay one family. Fixes DeusData#725 Signed-off-by: rudi193-cmd <rudi193@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thank you — and the scoping here is the part I want to call out. You fixed the cross-language case and explicitly left unique_name to #1572 and receiver-type disambiguation to #1555, rather than sweeping all three into one diff. That is exactly right for a graph-correctness change: each of those has a different failure mode and deserves to fail its own test. Treating JS/TS/TSX as one family is the detail most people would have missed. Dropping a .ts → .tsx call to fix a Python-vs-JS collision would have traded one wrong answer for another, and silently — which in this project counts as a correctness regression, not a tradeoff. Fair warning on timing: our CI is badly backed up tonight (8 runs queued, no runners allocating) because we are pushing a v0.10.5 that fixes a batch of install and startup blockers. Your PR is queued behind that. It is a graph-quality fix rather than an operability blocker, so it will land after the release rather than in it — no reflection on the change, just the order the queue forces. I will review it properly once the backlog clears. |
Sorry, something went wrong.
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Sorry, something went wrong.
|
Merged (89f0cd4) — thank you! Guarding both emit paths (the header comment at lsp_resolve.h:16 confirming those are exactly the two was a nice touch), keeping unknown-extension targets, and explicitly deferring unique_name to #1572 is precisely the conservative shape we want for graph-precision changes. On your question: no collision with the #1572 work from our side — that track targets unique_name resolution and will build on top of, not against, this suffix_match guard. #725 closed. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Test plan
Made with Cursor