fix: unbreak main — stdin-gate #1359 guards + Windows search_code UTF-8 pipe - #1704
Merged
DeusData merged 2 commits intoAug 18, 2026
Merged
fix: unbreak main — stdin-gate #1359 guards + Windows search_code UTF-8 pipe#1704DeusData merged 2 commits into
DeusData merged 2 commits into
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
…ero-argument tool #1181 gave list_projects pagination parameters, retiring the last empty-properties schema — and the two #1359 regression tests leaned on list_projects as their live zero-argument example, so main went red the moment the merge train composed (the PR was green on its July base, which predated these tests). The gate's schema→decision core is split behind a CBM_CLI_ENABLE_TEST_API seam, so the zero-argument branch stays pinned directly (empty properties, absent properties, populated properties) regardless of what the registry ships; list_projects now asserts its NEW truth (piped args accepted, TTY still refused); and the schema↔gate parity sweep keeps running over every tool without the impossible >=1 zero-argument floor. Production behavior is unchanged — this is the tests catching up with an intended schema change, plus a seam so they never again depend on a shipped example. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
PowerShell 5.1 encodes stdout for a native-process pipe in the console OEM codepage, so raw search content containing characters the inherited CP cannot carry (Cyrillic under CP437/850, ...) reached collect_grep_matches as '?' — and whether it degraded depended entirely on which console the server happened to inherit. That surfaced as the intermittent test_mcp raw-Русский mojibake on the windows CI leg and means real Windows users in a default console get '?' for all non-ASCII search_code raw content. Every generated command now pins [Console]::OutputEncoding to UTF-8, so the pipe is codepage-independent by construction. The read side needs no pin: Select-String decodes BOM-less UTF-8 via .NET StreamReader defaults. A Windows-side builder test asserts all five command variants carry the prelude. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This was referenced Aug 18, 2026
DeusData
added a commit
to ertankucukoglu/codebase-memory-mcp
that referenced
this pull request
Aug 18, 2026
Trivial insertion-point collision in tests/test_mcp.c: both this branch and main (DeusData#1704's UTF-8 pin) add a Windows search_code test at the same spot. Both tests kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two targeted fixes, one goal: every CI leg on main is currently red by one of these, and they deadlock as separate PRs (each is red on the leg the other one fixes, and ci-ok is a required check).
1. stdin-gate tests vs #1181 composition (mac/diag/lsan + cli shards) — #1181 gave list_projects pagination parameters, retiring the last empty-properties schema; the two #1359 regression tests leaned on it as their live zero-argument example. The gate's schema→decision core is now split behind a CBM_CLI_ENABLE_TEST_API seam so the zero-argument branch stays pinned regardless of what the registry ships; list_projects asserts its new truth (piped args accepted, TTY refused). Production unchanged.
2. Windows search_code mojibake (windows 2/2, now persistent) — PowerShell 5.1 encodes stdout for a native-process pipe in the console OEM codepage, so non-ASCII raw search content degrades to '?' depending on the inherited console (test_mcp.c:4427 raw-Русский; reproduced twice in a row on this PR's leg). Every generated command now pins [Console]::OutputEncoding to UTF-8; a Windows-side test asserts all five builder variants carry the prelude. Originally PR #1707, folded in here to break the deadlock.
🤖 Generated with Claude Code
https://claude.ai/code/session_018RiRAw9RQhvCoshqe7eZHV